Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0a9019cc authored by Dan Carpenter's avatar Dan Carpenter Committed by Greg Kroah-Hartman
Browse files

Staging: wilc1000: unlock on error in init_chip() 



When there is an error in init_bus() then we need to call release_bus()
before we return.

Fixes: c5c77ba1 ("staging: wilc1000: Add SDIO/SPI 802.11 driver")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent fe2570fb

drivers/staging/wilc1000/wilc_wlan.c

+4 −3
Original line number Diff line number Diff line
@@ -1252,21 +1252,22 @@ static u32 init_chip(struct net_device *dev) 
		ret = wilc->hif_func->hif_read_reg(wilc, 0x1118, &reg);

		if (!ret) {

			netdev_err(dev, "fail read reg 0x1118\n");

			return ret;

			goto release;

		}

		reg |= BIT(0);

		ret = wilc->hif_func->hif_write_reg(wilc, 0x1118, reg);

		if (!ret) {

			netdev_err(dev, "fail write reg 0x1118\n");

			return ret;

			goto release;

		}

		ret = wilc->hif_func->hif_write_reg(wilc, 0xc0000, 0x71);

		if (!ret) {

			netdev_err(dev, "fail write reg 0xc0000\n");

			return ret;

			goto release;

		}

	}



release:

	release_bus(wilc, WILC_BUS_RELEASE_ONLY);



	return ret;