Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0a81a87c authored by Eric Huang's avatar Eric Huang Committed by Alex Deucher
Browse files

drm/amd/powerplay: remove useless soft pptable in Asic related backend 



The soft pptable was used for re-uploading pptable as cache, but since
previous commits, the generic codes for uploading pptable are used and
backend is released during resetting powerplay. So it becomes redundance.

Reviewed-by: default avatarAlex Deucher <alexander.deucher@amd.com>
Signed-off-by: default avatarEric Huang <JinHuiEric.Huang@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent e8c1fe9f

drivers/gpu/drm/amd/powerplay/hwmgr/fiji_hwmgr.c

+0 −7
Original line number Diff line number Diff line
@@ -581,13 +581,6 @@ static int fiji_patch_boot_state(struct pp_hwmgr *hwmgr, 


static int fiji_hwmgr_backend_fini(struct pp_hwmgr *hwmgr)

{

	struct fiji_hwmgr *data = (struct fiji_hwmgr *)(hwmgr->backend);



	if (data->soft_pp_table) {

		kfree(data->soft_pp_table);

		data->soft_pp_table = NULL;

	}



	return phm_hwmgr_backend_fini(hwmgr);

}

drivers/gpu/drm/amd/powerplay/hwmgr/fiji_hwmgr.h

+0 −3
Original line number Diff line number Diff line
@@ -302,9 +302,6 @@ struct fiji_hwmgr { 
	bool                           pg_acp_init;

	bool                           frtc_enabled;

	bool                           frtc_status_changed;



	/* soft pptable for re-uploading into smu */

	void *soft_pp_table;

};



/* To convert to Q8.8 format for firmware */

drivers/gpu/drm/amd/powerplay/hwmgr/polaris10_hwmgr.c

+0 −7
Original line number Diff line number Diff line
@@ -2739,13 +2739,6 @@ int polaris10_reset_asic_tasks(struct pp_hwmgr *hwmgr) 


int polaris10_hwmgr_backend_fini(struct pp_hwmgr *hwmgr)

{

	struct polaris10_hwmgr *data = (struct polaris10_hwmgr *)(hwmgr->backend);



	if (data->soft_pp_table) {

		kfree(data->soft_pp_table);

		data->soft_pp_table = NULL;

	}



	return phm_hwmgr_backend_fini(hwmgr);

}

drivers/gpu/drm/amd/powerplay/hwmgr/polaris10_hwmgr.h

+0 −4
Original line number Diff line number Diff line
@@ -309,10 +309,6 @@ struct polaris10_hwmgr { 
	uint32_t                           up_hyst;

	uint32_t disable_dpm_mask;

	bool apply_optimized_settings;



	/* soft pptable for re-uploading into smu */

	void *soft_pp_table;



	uint32_t                              avfs_vdroop_override_setting;

	bool                                  apply_avfs_cks_off_voltage;

};

drivers/gpu/drm/amd/powerplay/hwmgr/tonga_hwmgr.c

+0 −7
Original line number Diff line number Diff line
@@ -4422,13 +4422,6 @@ int tonga_reset_asic_tasks(struct pp_hwmgr *hwmgr) 


int tonga_hwmgr_backend_fini(struct pp_hwmgr *hwmgr)

{

	struct tonga_hwmgr *data = (struct tonga_hwmgr *)(hwmgr->backend);



	if (data->soft_pp_table) {

		kfree(data->soft_pp_table);

		data->soft_pp_table = NULL;

	}



	return phm_hwmgr_backend_fini(hwmgr);

}