Commit 0a6f3948 authored Jul 06, 2023 by Sui Jingfeng Committed by Greg Kroah-Hartman Sep 23, 2023

drm/mediatek: Fix potential memory leak if vmap() fail



[ Upstream commit 379091e0f6d179d1a084c65de90fa44583b14a70 ]

Also return -ENOMEM if such a failure happens, the implement should take
responsibility for the error handling.

Fixes: 3df64d7b ("drm/mediatek: Implement gem prime vmap/vunmap function")
Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
Reviewed-by: Alexandre Mergnat <amergnat@baylibre.com>
Signed-off-by: Sui Jingfeng <suijingfeng@loongson.cn>
Reviewed-by: CK Hu <ck.hu@mediatek.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Link: https://patchwork.kernel.org/project/dri-devel/patch/20230706134000.130098-1-suijingfeng@loongson.cn/


Signed-off-by: Chun-Kuang Hu <chunkuang.hu@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent f6364fa7

drivers/gpu/drm/mediatek/mtk_drm_gem.c

+5 −1

Original line number	Diff line number	Diff line
		@@ -267,7 +267,11 @@ void mtk_drm_gem_prime_vmap(struct drm_gem_object obj)
		}
		mtk_gem->kvaddr = vmap(mtk_gem->pages, npages, VM_MAP,
		pgprot_writecombine(PAGE_KERNEL));

		if (!mtk_gem->kvaddr) {
		kfree(sgt);
		kfree(mtk_gem->pages);
		return ERR_PTR(-ENOMEM);
		}
		out:
		kfree(sgt);