Commit 0a6afc83 authored Jun 04, 2023 by Christophe JAILLET Committed by Greg Kroah-Hartman Jul 27, 2023

usb: dwc3: qcom: Release the correct resources in dwc3_qcom_remove()



[ Upstream commit 8fd95da2cfb5046c4bb5a3cdc9eb7963ba8b10dd ]

In the probe, some resources are allocated with
dwc3_qcom_of_register_core() or dwc3_qcom_acpi_register_core(). The
corresponding resources are already coorectly freed in the error handling
path of the probe, but not in the remove function.

Fix it.

Fixes: 2bc02355 ("usb: dwc3: qcom: Add support for booting with ACPI")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: Andrew Halaney <ahalaney@redhat.com>
Message-ID: <c0215a84cdf18fb3514c81842783ec53cf149deb.1685891059.git.christophe.jaillet@wanadoo.fr>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent becd0968

drivers/usb/dwc3/dwc3-qcom.c

+5 −1

Original line number	Diff line number	Diff line
		@@ -704,10 +704,14 @@ static int dwc3_qcom_probe(struct platform_device *pdev)
		static int dwc3_qcom_remove(struct platform_device *pdev)
		{
		struct dwc3_qcom *qcom = platform_get_drvdata(pdev);
		struct device_node *np = pdev->dev.of_node;
		struct device *dev = &pdev->dev;
		int i;

		of_platform_depopulate(dev);
		if (np)
		of_platform_depopulate(&pdev->dev);
		else
		platform_device_put(pdev);

		for (i = qcom->num_clocks - 1; i >= 0; i--) {
		clk_disable_unprepare(qcom->clks[i]);