Commit 0a4c9265 authored Jan 23, 2019 by Gustavo A. R. Silva

fs: mark expected switch fall-throughs

In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.

This patch fixes the following warnings:

fs/affs/affs.h:124:38: warning: this statement may fall through [-Wimplicit-fallthrough=]
fs/configfs/dir.c:1692:11: warning: this statement may fall through [-Wimplicit-fallthrough=]
fs/configfs/dir.c:1694:7: warning: this statement may fall through [-Wimplicit-fallthrough=]
fs/ceph/file.c:249:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
fs/ext4/hash.c:233:15: warning: this statement may fall through [-Wimplicit-fallthrough=]
fs/ext4/hash.c:246:15: warning: this statement may fall through [-Wimplicit-fallthrough=]
fs/ext2/inode.c:1237:7: warning: this statement may fall through [-Wimplicit-fallthrough=]
fs/ext2/inode.c:1244:7: warning: this statement may fall through [-Wimplicit-fallthrough=]
fs/ext4/indirect.c:1182:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
fs/ext4/indirect.c:1188:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
fs/ext4/indirect.c:1432:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
fs/ext4/indirect.c:1440:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
fs/f2fs/node.c:618:8: warning: this statement may fall through [-Wimplicit-fallthrough=]
fs/f2fs/node.c:620:8: warning: this statement may fall through [-Wimplicit-fallthrough=]
fs/btrfs/ref-verify.c:522:15: warning: this statement may fall through [-Wimplicit-fallthrough=]
fs/gfs2/bmap.c:711:7: warning: this statement may fall through [-Wimplicit-fallthrough=]
fs/gfs2/bmap.c:722:7: warning: this statement may fall through [-Wimplicit-fallthrough=]
fs/jffs2/fs.c:339:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
fs/nfsd/nfs4proc.c:429:12: warning: this statement may fall through [-Wimplicit-fallthrough=]
fs/ufs/util.h:62:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
fs/ufs/util.h:43:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
fs/fcntl.c:770:7: warning: this statement may fall through [-Wimplicit-fallthrough=]
fs/seq_file.c:319:10: warning: this statement may fall through [-Wimplicit-fallthrough=]
fs/libfs.c:148:11: warning: this statement may fall through [-Wimplicit-fallthrough=]
fs/libfs.c:150:7: warning: this statement may fall through [-Wimplicit-fallthrough=]
fs/signalfd.c:178:7: warning: this statement may fall through [-Wimplicit-fallthrough=]
fs/locks.c:1473:16: warning: this statement may fall through [-Wimplicit-fallthrough=]

Warning level 3 was used: -Wimplicit-fallthrough=3

This patch is part of the ongoing efforts to enabling
-Wimplicit-fallthrough.

Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>

parent 17403fa2

fs/affs/super.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -487,7 +487,7 @@ static int affs_fill_super(struct super_block sb, void data, int silent)
		break;
		case MUFS_OFS:
		affs_set_opt(sbi->s_flags, SF_MUFS);
		/* fall thru */
		/* fall through */
		case FS_OFS:
		affs_set_opt(sbi->s_flags, SF_OFS);
		sb->s_flags \|= SB_NOEXEC;
		@@ -495,6 +495,7 @@ static int affs_fill_super(struct super_block sb, void data, int silent)
		case MUFS_DCOFS:
		case MUFS_INTLOFS:
		affs_set_opt(sbi->s_flags, SF_MUFS);
		/* fall through */
		case FS_DCOFS:
		case FS_INTLOFS:
		affs_set_opt(sbi->s_flags, SF_INTL);

fs/btrfs/ref-verify.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -520,6 +520,7 @@ static int process_leaf(struct btrfs_root *root,
		switch (key.type) {
		case BTRFS_EXTENT_ITEM_KEY:
		*num_bytes = key.offset;
		/* fall through */
		case BTRFS_METADATA_ITEM_KEY:
		*bytenr = key.objectid;
		ret = process_extent_item(fs_info, path, &key, i,

fs/btrfs/volumes.h

+1 −0

Original line number	Diff line number	Diff line
		@@ -390,6 +390,7 @@ static inline enum btrfs_map_op btrfs_op(struct bio *bio)
		return BTRFS_MAP_WRITE;
		default:
		WARN_ON_ONCE(1);
		/* fall through */
		case REQ_OP_READ:
		return BTRFS_MAP_READ;
		}

fs/ceph/file.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -247,6 +247,7 @@ static int ceph_init_file(struct inode inode, struct file file, int fmode)
		case S_IFREG:
		ceph_fscache_register_inode_cookie(inode);
		ceph_fscache_file_set_cookie(inode, file);
		/* fall through */
		case S_IFDIR:
		ret = ceph_init_file_info(inode, file, fmode,
		S_ISDIR(inode->i_mode));

fs/configfs/dir.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -1690,9 +1690,11 @@ static loff_t configfs_dir_lseek(struct file *file, loff_t offset, int whence)
		switch (whence) {
		case 1:
		offset += file->f_pos;
		/* fall through */
		case 0:
		if (offset >= 0)
		break;
		/* fall through */
		default:
		return -EINVAL;
		}