Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0a3b8b2b authored by Cong Wang's avatar Cong Wang Committed by David S. Miller
Browse files

tipc: orphan sock in tipc_release() 



Before we unlock the sock in tipc_release(), we have to
detach sk->sk_socket from sk, otherwise a parallel
tipc_sk_fill_sock_diag() could stil read it after we
free this socket.

Fixes: c30b70de ("tipc: implement socket diagnostics for AF_TIPC")
Reported-and-tested-by: default avatar <syzbot+48804b87c16588ad491d@syzkaller.appspotmail.com>
Cc: Jon Maloy <jon.maloy@ericsson.com>
Cc: Ying Xue <ying.xue@windriver.com>
Signed-off-by: default avatarCong Wang <xiyou.wangcong@gmail.com>
Acked-by: default avatarYing Xue <ying.xue@windriver.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent e65a9e48

net/tipc/socket.c

+1 −0
Original line number Diff line number Diff line
@@ -576,6 +576,7 @@ static int tipc_release(struct socket *sock) 
	sk_stop_timer(sk, &sk->sk_timer);

	tipc_sk_remove(tsk);



	sock_orphan(sk);

	/* Reject any messages that accumulated in backlog queue */

	release_sock(sk);

	tipc_dest_list_purge(&tsk->cong_links);