Commit 0a30ba50 authored Aug 08, 2019 by Valdis Kletnieks Committed by Pablo Neira Ayuso Aug 13, 2019

netfilter: nf_nat_proto: make tables static

Sparse warns about two tables not being declared.

CHECK net/netfilter/nf_nat_proto.c
net/netfilter/nf_nat_proto.c:725:26: warning: symbol 'nf_nat_ipv4_ops' was not declared. Should it be static?
net/netfilter/nf_nat_proto.c:964:26: warning: symbol 'nf_nat_ipv6_ops' was not declared. Should it be static?

And in fact they can indeed be static.

Signed-off-by: Valdis Kletnieks <valdis.kletnieks@vt.edu>
Acked-by: Florian Westphal <fw@strlen.de>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>

parent 5785cf15

net/netfilter/nf_nat_proto.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -722,7 +722,7 @@ nf_nat_ipv4_local_fn(void priv, struct sk_buff skb,
		return ret;
		}

		const struct nf_hook_ops nf_nat_ipv4_ops[] = {
		static const struct nf_hook_ops nf_nat_ipv4_ops[] = {
		/* Before packet filtering, change destination */
		{
		.hook = nf_nat_ipv4_in,
		@@ -961,7 +961,7 @@ nf_nat_ipv6_local_fn(void priv, struct sk_buff skb,
		return ret;
		}

		const struct nf_hook_ops nf_nat_ipv6_ops[] = {
		static const struct nf_hook_ops nf_nat_ipv6_ops[] = {
		/* Before packet filtering, change destination */
		{
		.hook = nf_nat_ipv6_in,