Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0a01dc77 authored by Andy Shevchenko's avatar Andy Shevchenko Committed by Greg Kroah-Hartman
Browse files

leds: lt3593: Put fwnode in any case during ->probe() 



[ Upstream commit 7e1baaaa2407a642ea19b58e214fab9a69cda1d7 ]

device_get_next_child_node() bumps a reference counting of a returned variable.
We have to balance it whenever we return to the caller.

Fixes: 8cd7d6da ("leds: lt3593: Add device tree probing glue")
Cc: Daniel Mack <daniel@zonque.org>
Signed-off-by: default avatarAndy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: default avatarPavel Machek <pavel@ucw.cz>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent e39c7356

drivers/leds/leds-lt3593.c

+2 −3
Original line number Diff line number Diff line
@@ -103,10 +103,9 @@ static int lt3593_led_probe(struct platform_device *pdev) 
	init_data.default_label = ":";



	ret = devm_led_classdev_register_ext(dev, &led_data->cdev, &init_data);

	if (ret < 0) {

	fwnode_handle_put(child);

	if (ret < 0)

		return ret;

	}



	led_data->cdev.dev->of_node = dev->of_node;

	platform_set_drvdata(pdev, led_data);