Commit 09e7f280 authored Sep 02, 2019 by Yizhuo Committed by Andy Shevchenko Sep 07, 2019

platform/x86: compal-laptop: Initialize "value" in ec_read_u8()



In function ec_read_u8(), variable "value" could be uninitialized
if ec_read() fails. However, "value" is returned directly and used
in its callers. This is potentially unsafe.

Signed-off-by: Yizhuo <yzhai003@ucr.edu>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

parent 37d960a4

drivers/platform/x86/compal-laptop.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -226,7 +226,7 @@ static const unsigned char pwm_lookup_table[256] = {
		/* General access */
		static u8 ec_read_u8(u8 addr)
		{
		u8 value;
		u8 value = 0;
		ec_read(addr, &value);
		return value;
		}