Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 09d4d964 authored by Julia Lawall's avatar Julia Lawall Committed by Masahiro Yamada
Browse files

Coccinelle: doubletest: reduce side effect false positives 



Ensure that the cited expression is not a function call or an
assignment to reduce the chance of false positives.

Slightly modify the warning message to indicate another source
of false positves.

Signed-off-by: default avatarJulia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: default avatarMasahiro Yamada <yamada.masahiro@socionext.com>
parent d6c6ab93

scripts/coccinelle/tests/doubletest.cocci

+26 −8
Original line number Diff line number Diff line 
/// Find &&/|| operations that include the same argument more than once

//# A common source of false positives is when the argument performs a side

//# effect.

//# A common source of false positives is when the expression, or

//# another expresssion in the same && or || operation, performs a

//# side effect.

///

// Confidence: Moderate

// Copyright: (C) 2010 Nicolas Palix, DIKU.  GPLv2.
@@ -20,20 +21,37 @@ position p; 
@@



(

* E@p

  || ... || E

 E@p || ... || E

|

* E@p

  && ... && E

 E@p && ... && E

)



@script:python depends on org@

@bad@

expression r.E,e1,e2,fn;

position r.p;

assignment operator op;

@@



(

E@p

&

 <+... \(fn(...)\|e1 op e2\|e1++\|e1--\|++e1\|--e1\) ...+>

)



@depends on context && !bad@

expression r.E;

position r.p;

@@



*E@p



@script:python depends on org && !bad@

p << r.p;

@@



cocci.print_main("duplicated argument to && or ||",p)



@script:python depends on report@

@script:python depends on report && !bad@

p << r.p;

@@