Commit 09cb47a2 authored Jan 21, 2010 by Julia Lawall Committed by David S. Miller Jan 21, 2010

net/sctp: Eliminate useless code

The variable newinet is initialized twice to the same (side effect-free)
expression.  Drop one initialization.

A simplified version of the semantic match that finds this problem is:
(http://coccinelle.lip6.fr/

)

// <smpl>
@forall@
idexpression *x;
identifier f!=ERR_PTR;
@@

x = f(...)
... when != x
(
x = f(...,<+...x...+>,...)
|
* x = f(...)
)
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Acked-by: Vlad Yasevich <vladislav.yasevich@hp.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 17660f81

net/sctp/socket.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -6359,7 +6359,7 @@ void sctp_copy_sock(struct sock newsk, struct sock sk,
		struct sctp_association *asoc)
		{
		struct inet_sock *inet = inet_sk(sk);
		struct inet_sock *newinet = inet_sk(newsk);
		struct inet_sock *newinet;

		newsk->sk_type = sk->sk_type;
		newsk->sk_bound_dev_if = sk->sk_bound_dev_if;