Commit 093c4821 authored Dec 26, 2018 by Wenwen Wang Committed by Jens Axboe Dec 29, 2018

gdrom: fix a memory leak bug



In probe_gdrom(), the buffer pointed by 'gd.cd_info' is allocated through
kzalloc() and is used to hold the information of the gdrom device. To
register and unregister the device, the pointer 'gd.cd_info' is passed to
the functions register_cdrom() and unregister_cdrom(), respectively.
However, this buffer is not freed after it is used, which can cause a
memory leak bug.

This patch simply frees the buffer 'gd.cd_info' in exit_gdrom() to fix the
above issue.

Signed-off-by: Wenwen Wang <wang6495@umn.edu>
Signed-off-by: Jens Axboe <axboe@kernel.dk>

parent d52c499b

drivers/cdrom/gdrom.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -873,6 +873,7 @@ static void __exit exit_gdrom(void)
		platform_device_unregister(pd);
		platform_driver_unregister(&gdrom_driver);
		kfree(gd.toc);
		kfree(gd.cd_info);
		}

		module_init(init_gdrom);