Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 08c1ac3b authored by Jose Abreu's avatar Jose Abreu Committed by David S. Miller
Browse files

net: stmmac: xgmac: Fix AV Feature detection 



Fix incorrect precedence of operators. For reference: AV implies AV
Feature but RAV implies only RX side AV Feature. As we want full AV
features we need to check RAV.

Fixes: c2b69474 ("net: stmmac: xgmac: Correct RAVSEL field interpretation")
Signed-off-by: default avatarJose Abreu <Jose.Abreu@synopsys.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 97add93f

drivers/net/ethernet/stmicro/stmmac/dwxgmac2_dma.c

+1 −1
Original line number Diff line number Diff line
@@ -369,7 +369,7 @@ static void dwxgmac2_get_hw_feature(void __iomem *ioaddr, 
	dma_cap->eee = (hw_cap & XGMAC_HWFEAT_EEESEL) >> 13;

	dma_cap->atime_stamp = (hw_cap & XGMAC_HWFEAT_TSSEL) >> 12;

	dma_cap->av = (hw_cap & XGMAC_HWFEAT_AVSEL) >> 11;

	dma_cap->av &= !(hw_cap & XGMAC_HWFEAT_RAVSEL) >> 10;

	dma_cap->av &= !((hw_cap & XGMAC_HWFEAT_RAVSEL) >> 10);

	dma_cap->arpoffsel = (hw_cap & XGMAC_HWFEAT_ARPOFFSEL) >> 9;

	dma_cap->rmon = (hw_cap & XGMAC_HWFEAT_MMCSEL) >> 8;

	dma_cap->pmt_magic_frame = (hw_cap & XGMAC_HWFEAT_MGKSEL) >> 7;