Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 08aba42f authored by Arnd Bergmann's avatar Arnd Bergmann Committed by Kalle Valo
Browse files

rtlwifi: use s8 instead of char 



Compiling the rtlwifi drivers for ARM with gcc -Wextra warns about lots of
incorrect code that results from 'char' being unsigned here, e.g.

realtek/rtlwifi/rc.c:113:18: error: comparison is always true due to limited range of data type [-Werror=type-limits]
realtek/rtlwifi/rtl8188ee/dm.c:1070:22: error: comparison is always false due to limited range of data type [-Werror=type-limits]
realtek/rtlwifi/rtl8192ce/trx.c:54:16: error: comparison is always false due to limited range of data type [-Werror=type-limits]
realtek/rtlwifi/rtl8192cu/mac.c:601:16: error: comparison is always false due to limited range of data type [-Werror=type-limits]
realtek/rtlwifi/rtl8192de/trx.c:53:16: error: comparison is always false due to limited range of data type [-Werror=type-limits]
realtek/rtlwifi/rtl8192ee/phy.c:1268:12: error: comparison is always true due to limited range of data type [-Werror=type-limits]
realtek/rtlwifi/rtl8192se/rf.c:150:20: error: comparison is always false due to limited range of data type [-Werror=type-limits]
realtek/rtlwifi/rtl8723be/dm.c:877:29: error: comparison is always false due to limited range of data type [-Werror=type-limits]
realtek/rtlwifi/rtl8723be/phy.c:386:16: error: comparison is always true due to limited range of data type [-Werror=type-limits]
realtek/rtlwifi/rtl8821ae/dm.c:1514:38: error: comparison is always false due to limited range of data type [-Werror=type-limits]
realtek/rtlwifi/rtl8821ae/phy.c:1558:11: error: comparison is always false due to limited range of data type [-Werror=type-limits]
realtek/rtlwifi/rtl8821ae/phy.c:386:24: error: comparison is always false due to limited range of data type [-Werror=type-limits]
realtek/rtlwifi/rtl8821ae/trx.c:55:12: error: comparison is always false due to limited range of data type [-Werror=type-limits]
realtek/rtlwifi/stats.c:31:16: error: comparison is always false due to limited range of data type [-Werror=type-limits]

This patch changes all uses of 'char' in this driver that refer to
8-bit integers to use 's8' instead, which is signed on all architectures.

Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
parent f52b041a

drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c

+1 −1
Original line number Diff line number Diff line
@@ -901,7 +901,7 @@ void exhalbtc_stack_update_profile_info(void) 
{

}



void exhalbtc_update_min_bt_rssi(char bt_rssi)

void exhalbtc_update_min_bt_rssi(s8 bt_rssi)

{

	struct btc_coexist *btcoexist = &gl_bt_coexist;

drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.h

+2 −2
Original line number Diff line number Diff line
@@ -433,7 +433,7 @@ struct btc_stack_info { 
	u8 num_of_hid;

	bool pan_exist;

	bool unknown_acl_exist;

	char min_bt_rssi;

	s8 min_bt_rssi;

};



struct btc_statistics {
@@ -537,7 +537,7 @@ void exhalbtc_dbg_control(struct btc_coexist *btcoexist, u8 code, u8 len, 
void exhalbtc_stack_update_profile_info(void);

void exhalbtc_set_hci_version(u16 hci_version);

void exhalbtc_set_bt_patch_version(u16 bt_hci_version, u16 bt_patch_version);

void exhalbtc_update_min_bt_rssi(char bt_rssi);

void exhalbtc_update_min_bt_rssi(s8 bt_rssi);

void exhalbtc_set_bt_exist(bool bt_exist);

void exhalbtc_set_chip_type(u8 chip_type);

void exhalbtc_set_ant_num(struct rtl_priv *rtlpriv, u8 type, u8 ant_num);

drivers/net/wireless/realtek/rtlwifi/rc.c

+1 −1
Original line number Diff line number Diff line
@@ -94,7 +94,7 @@ static void _rtl_rc_rate_set_series(struct rtl_priv *rtlpriv, 
				    struct ieee80211_sta *sta,

				    struct ieee80211_tx_rate *rate,

				    struct ieee80211_tx_rate_control *txrc,

				    u8 tries, char rix, int rtsctsenable,

				    u8 tries, s8 rix, int rtsctsenable,

				    bool not_data)

{

	struct rtl_mac *mac = rtl_mac(rtlpriv);

drivers/net/wireless/realtek/rtlwifi/rtl8188ee/dm.c

+2 −2
Original line number Diff line number Diff line
@@ -886,7 +886,7 @@ static void dm_txpower_track_cb_therm(struct ieee80211_hw *hw) 
	u8 thermalvalue_avg_count = 0;

	u32 thermalvalue_avg = 0;

	long  ele_d, temp_cck;

	char ofdm_index[2], cck_index = 0,

	s8 ofdm_index[2], cck_index = 0,

		ofdm_index_old[2] = {0, 0}, cck_index_old = 0;

	int i = 0;

	/*bool is2t = false;*/
@@ -898,7 +898,7 @@ static void dm_txpower_track_cb_therm(struct ieee80211_hw *hw) 
	/*0.1 the following TWO tables decide the

	 *final index of OFDM/CCK swing table

	 */

	char delta_swing_table_idx[2][15]  = {

	s8 delta_swing_table_idx[2][15]  = {

		{0, 0, 2, 3, 4, 4, 5, 6, 7, 7, 8, 9, 10, 10, 11},

		{0, 0, -1, -2, -3, -4, -4, -4, -4, -5, -7, -8, -9, -9, -10}

	};

drivers/net/wireless/realtek/rtlwifi/rtl8188ee/trx.c

+1 −1
Original line number Diff line number Diff line
@@ -59,7 +59,7 @@ static void _rtl88ee_query_rxphystatus(struct ieee80211_hw *hw, 
	struct phy_status_rpt *phystrpt =

		(struct phy_status_rpt *)p_drvinfo;

	struct rtl_dm *rtldm = rtl_dm(rtl_priv(hw));

	char rx_pwr_all = 0, rx_pwr[4];

	s8 rx_pwr_all = 0, rx_pwr[4];

	u8 rf_rx_num = 0, evm, pwdb_all;

	u8 i, max_spatial_stream;

	u32 rssi, total_rssi = 0;