Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 086f9efa authored by Stephen Boyd's avatar Stephen Boyd Committed by Joerg Roedel
Browse files

iommu: Remove dev_err() usage after platform_get_irq() 



We don't need dev_err() messages when platform_get_irq() fails now that
platform_get_irq() prints an error message itself when something goes
wrong. Let's remove these prints with a simple semantic patch.

// <smpl>
@@
expression ret;
struct platform_device *E;
@@

ret =
(
platform_get_irq(E, ...)
|
platform_get_irq_byname(E, ...)
);

if ( \( ret < 0 \| ret <= 0 \) )
{
(
-if (ret != -EPROBE_DEFER)
-{ ...
-dev_err(...);
-... }
|
...
-dev_err(...);
)
...
}
// </smpl>

While we're here, remove braces on if statements that only have one
statement (manually).

Cc: Joerg Roedel <joro@8bytes.org>
Cc: iommu@lists.linux-foundation.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarStephen Boyd <swboyd@chromium.org>
Signed-off-by: default avatarJoerg Roedel <jroedel@suse.de>
parent e21a712a

drivers/iommu/exynos-iommu.c

+1 −3
Original line number Diff line number Diff line
@@ -583,10 +583,8 @@ static int __init exynos_sysmmu_probe(struct platform_device *pdev) 
		return PTR_ERR(data->sfrbase);



	irq = platform_get_irq(pdev, 0);

	if (irq <= 0) {

		dev_err(dev, "Unable to find IRQ resource\n");

	if (irq <= 0)

		return irq;

	}



	ret = devm_request_irq(dev, irq, exynos_sysmmu_irq, 0,

				dev_name(dev), data);

drivers/iommu/msm_iommu.c

+0 −1
Original line number Diff line number Diff line
@@ -750,7 +750,6 @@ static int msm_iommu_probe(struct platform_device *pdev) 


	iommu->irq = platform_get_irq(pdev, 0);

	if (iommu->irq < 0) {

		dev_err(iommu->dev, "could not get iommu irq\n");

		ret = -ENODEV;

		goto fail;

	}

drivers/iommu/qcom_iommu.c

+1 −3
Original line number Diff line number Diff line
@@ -696,10 +696,8 @@ static int qcom_iommu_ctx_probe(struct platform_device *pdev) 
		return PTR_ERR(ctx->base);



	irq = platform_get_irq(pdev, 0);

	if (irq < 0) {

		dev_err(dev, "failed to get irq\n");

	if (irq < 0)

		return -ENODEV;

	}



	/* clear IRQs before registering fault handler, just in case the

	 * boot-loader left us a surprise: