Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 084a804e authored by Roger Quadros's avatar Roger Quadros Committed by Felipe Balbi
Browse files

usb: dwc3: Fix lock-up on ID change during system suspend/resume 



To reproduce the lock up do the following
- connect otg host adapter and a USB device to the dual-role port
so that it is in host mode.
- suspend to mem.
- disconnect otg adapter.
- resume the system.

If we call dwc3_host_exit() before tasks are thawed
xhci_plat_remove() seems to lock up at the second usb_remove_hcd() call.

To work around this we queue the _dwc3_set_mode() work on
the system_freezable_wq.

Fixes: 41ce1456 ("usb: dwc3: core: make dwc3_set_mode() work properly")
Cc: <stable@vger.kernel.org> # v4.12+
Suggested-by: default avatarManu Gautam <mgautam@codeaurora.org>
Signed-off-by: default avatarRoger Quadros <rogerq@ti.com>
Signed-off-by: default avatarFelipe Balbi <felipe.balbi@linux.intel.com>
parent 4a3928c6

drivers/usb/dwc3/core.c

+1 −1
Original line number Diff line number Diff line
@@ -175,7 +175,7 @@ void dwc3_set_mode(struct dwc3 *dwc, u32 mode) 
	dwc->desired_dr_role = mode;

	spin_unlock_irqrestore(&dwc->lock, flags);



	queue_work(system_power_efficient_wq, &dwc->drd_work);

	queue_work(system_freezable_wq, &dwc->drd_work);

}



u32 dwc3_core_fifo_space(struct dwc3_ep *dep, u8 type)