Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 08474c1a authored by Jiri Pirko's avatar Jiri Pirko Committed by David S. Miller
Browse files

devlink: introduce a helper to generate physical port names 



Each driver implements physical port name generation by itself. However
as devlink has all needed info, it can easily do the job for all its
users. So implement this helper in devlink.

Signed-off-by: default avatarJiri Pirko <jiri@mellanox.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 5ec1380a

include/net/devlink.h

+9 −0
Original line number Original line Diff line number Diff line
@@ -378,6 +378,8 @@ void devlink_port_attrs_set(struct devlink_port *devlink_port, 
			    enum devlink_port_flavour flavour,

			    enum devlink_port_flavour flavour,

			    u32 port_number, bool split,

			    u32 port_number, bool split,

			    u32 split_subport_number);

			    u32 split_subport_number);

int devlink_port_get_phys_port_name(struct devlink_port *devlink_port,

				    char *name, size_t len);

int devlink_sb_register(struct devlink *devlink, unsigned int sb_index,

int devlink_sb_register(struct devlink *devlink, unsigned int sb_index,

			u32 size, u16 ingress_pools_count,

			u32 size, u16 ingress_pools_count,

			u16 egress_pools_count, u16 ingress_tc_count,

			u16 egress_pools_count, u16 ingress_tc_count,
@@ -482,6 +484,13 @@ static inline void devlink_port_attrs_set(struct devlink_port *devlink_port, 
{

{

}

}





static inline int

devlink_port_get_phys_port_name(struct devlink_port *devlink_port,

				char *name, size_t len)

{

	return -EOPNOTSUPP;

}



static inline int devlink_sb_register(struct devlink *devlink,

static inline int devlink_sb_register(struct devlink *devlink,

				      unsigned int sb_index, u32 size,

				      unsigned int sb_index, u32 size,

				      u16 ingress_pools_count,

				      u16 ingress_pools_count,

net/core/devlink.c

+33 −0
Original line number Original line Diff line number Diff line
@@ -3016,6 +3016,39 @@ void devlink_port_attrs_set(struct devlink_port *devlink_port, 
}

}

EXPORT_SYMBOL_GPL(devlink_port_attrs_set);

EXPORT_SYMBOL_GPL(devlink_port_attrs_set);





int devlink_port_get_phys_port_name(struct devlink_port *devlink_port,

				    char *name, size_t len)

{

	struct devlink_port_attrs *attrs = &devlink_port->attrs;

	int n = 0;



	if (!attrs->set)

		return -EOPNOTSUPP;



	switch (attrs->flavour) {

	case DEVLINK_PORT_FLAVOUR_PHYSICAL:

		if (!attrs->split)

			n = snprintf(name, len, "p%u", attrs->port_number);

		else

			n = snprintf(name, len, "p%us%u", attrs->port_number,

				     attrs->split_subport_number);

		break;

	case DEVLINK_PORT_FLAVOUR_CPU:

	case DEVLINK_PORT_FLAVOUR_DSA:

		/* As CPU and DSA ports do not have a netdevice associated

		 * case should not ever happen.

		 */

		WARN_ON(1);

		return -EINVAL;

	}



	if (n >= len)

		return -EINVAL;



	return 0;

}

EXPORT_SYMBOL_GPL(devlink_port_get_phys_port_name);



int devlink_sb_register(struct devlink *devlink, unsigned int sb_index,

int devlink_sb_register(struct devlink *devlink, unsigned int sb_index,

			u32 size, u16 ingress_pools_count,

			u32 size, u16 ingress_pools_count,

			u16 egress_pools_count, u16 ingress_tc_count,

			u16 egress_pools_count, u16 ingress_tc_count,