Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 08398462 authored by Christophe JAILLET's avatar Christophe JAILLET Committed by Greg Kroah-Hartman
Browse files

ASoC: qcom: q6dsp: Fix an off-by-one in q6adm_alloc_copp() 



[ Upstream commit 673f58f62ca6fc98979d1cf3fe89c3ff33f29b2e ]

find_first_zero_bit() returns MAX_COPPS_PER_PORT at max here.
So 'idx' should be tested with ">=" or the test can't match.

Fixes: 7b20b2be ("ASoC: qdsp6: q6adm: Add q6adm driver")
Signed-off-by: default avatarChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Link: https://lore.kernel.org/r/0fca3271649736053eb9649d87e1ca01b056be40.1658394124.git.christophe.jaillet@wanadoo.fr


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 3edcd134

sound/soc/qcom/qdsp6/q6adm.c

+1 −1
Original line number Diff line number Diff line
@@ -217,7 +217,7 @@ static struct q6copp *q6adm_alloc_copp(struct q6adm *adm, int port_idx) 
	idx = find_first_zero_bit(&adm->copp_bitmap[port_idx],

				  MAX_COPPS_PER_PORT);



	if (idx > MAX_COPPS_PER_PORT)

	if (idx >= MAX_COPPS_PER_PORT)

		return ERR_PTR(-EBUSY);



	c = kzalloc(sizeof(*c), GFP_ATOMIC);