Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 081a8ae2 authored by Colin Ian King's avatar Colin Ian King Committed by Darrick J. Wong
Browse files

xfs: fix uninitialized error variable 



A previous commit removed the initialization of variable 'error' to zero,
and can cause a bogus error return.  This occurs when error contains a
non-zero garbage value and the call to xchk_should_terminate detects a
pending fatal signal and checks for a zero error before setting it
to -EAGAIN. Fix the issue by initializing error to zero.

Fixes: b9454fe0 ("xfs: clean up the inode cluster checking in the inobt scrub")
Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Reviewed-by: default avatarDarrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: default avatarDarrick J. Wong <darrick.wong@oracle.com>
parent 66ae56a5

fs/xfs/scrub/ialloc.c

+1 −1
Original line number Diff line number Diff line
@@ -161,7 +161,7 @@ xchk_iallocbt_check_cluster_ifree( 
	bool				irec_free;

	bool				ino_inuse;

	bool				freemask_ok;

	int				error;

	int				error = 0;



	if (xchk_should_terminate(bs->sc, &error))

		return error;