Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 080f6b69 authored by Varun Prakash's avatar Varun Prakash Committed by Greg Kroah-Hartman
Browse files

nvmet-tcp: fix incomplete data digest send 



[ Upstream commit 102110efdff6beedece6ab9b51664c32ac01e2db ]

Current nvmet_try_send_ddgst() code does not check whether
all data digest bytes are transmitted, fix this by returning
-EAGAIN if all data digest bytes are not transmitted.

Fixes: 872d26a3 ("nvmet-tcp: add NVMe over TCP target driver")
Signed-off-by: default avatarVarun Prakash <varun@chelsio.com>
Reviewed-by: default avatarSagi Grimberg <sagi@grimberg.me>
Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 6c0ab2ca

drivers/nvme/target/tcp.c

+6 −1
Original line number Diff line number Diff line
@@ -631,10 +631,11 @@ static int nvmet_try_send_r2t(struct nvmet_tcp_cmd *cmd, bool last_in_batch) 
static int nvmet_try_send_ddgst(struct nvmet_tcp_cmd *cmd)

{

	struct nvmet_tcp_queue *queue = cmd->queue;

	int left = NVME_TCP_DIGEST_LENGTH - cmd->offset;

	struct msghdr msg = { .msg_flags = MSG_DONTWAIT };

	struct kvec iov = {

		.iov_base = (u8 *)&cmd->exp_ddgst + cmd->offset,

		.iov_len = NVME_TCP_DIGEST_LENGTH - cmd->offset

		.iov_len = left

	};

	int ret;
@@ -643,6 +644,10 @@ static int nvmet_try_send_ddgst(struct nvmet_tcp_cmd *cmd) 
		return ret;



	cmd->offset += ret;

	left -= ret;



	if (left)

		return -EAGAIN;



	if (queue->nvme_sq.sqhd_disabled) {

		cmd->queue->snd_cmd = NULL;