Commit 0804f371 authored Jan 09, 2023 by Vladimir Oltean Committed by Greg Kroah-Hartman May 17, 2023

asm-generic/io.h: suppress endianness warnings for readq() and writeq()

[ Upstream commit d564fa1ff19e893e2971d66e5c8f49dc1cdc8ffc ]

Commit c1d55d50139b ("asm-generic/io.h: Fix sparse warnings on
big-endian architectures") missed fixing the 64-bit accessors.

Arnd explains in the attached link why the casts are necessary, even if
__raw_readq() and __raw_writeq() do not take endian-specific types.

Link: https://lore.kernel.org/lkml/9105d6fc-880b-4734-857d-e3d30b87ccf6@app.fastmail.com/


Suggested-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 944ff47a

include/asm-generic/io.h

+2 −2

Original line number	Diff line number	Diff line
		@@ -190,7 +190,7 @@ static inline u64 readq(const volatile void __iomem *addr)
		u64 val;

		__io_br();
		val = __le64_to_cpu(__raw_readq(addr));
		val = __le64_to_cpu((__le64 __force)__raw_readq(addr));
		__io_ar(val);
		return val;
		}
		@@ -233,7 +233,7 @@ static inline void writel(u32 value, volatile void __iomem *addr)
		static inline void writeq(u64 value, volatile void __iomem *addr)
		{
		__io_bw();
		__raw_writeq(__cpu_to_le64(value), addr);
		__raw_writeq((u64 __force)__cpu_to_le64(value), addr);
		__io_aw();
		}
		#endif