Commit 07fceab3 authored Jan 02, 2023 by Miaoqian Lin Committed by Greg Kroah-Hartman Mar 11, 2023

irqchip/ti-sci: Fix refcount leak in ti_sci_intr_irq_domain_probe



[ Upstream commit 02298b7bae12936ca313975b02e7f98b06670d37 ]

of_irq_find_parent() returns a node pointer with refcount incremented,
We should use of_node_put() on it when not needed anymore.
Add missing of_node_put() to avoid refcount leak.

Fixes: cd844b07 ("irqchip/ti-sci-intr: Add support for Interrupt Router driver")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20230102085611.3955984-1-linmq006@gmail.com


Signed-off-by: Sasha Levin <sashal@kernel.org>

parent c7d78d36

drivers/irqchip/irq-ti-sci-intr.c

+1 −0

Original line number	Original line	Diff line number	Diff line
	@@ -205,6 +205,7 @@ static int ti_sci_intr_irq_domain_probe(struct platform_device *pdev)
	}		}

	parent_domain = irq_find_host(parent_node);		parent_domain = irq_find_host(parent_node);
			of_node_put(parent_node);
	if (!parent_domain) {		if (!parent_domain) {
	dev_err(dev, "Failed to find IRQ parent domain\n");		dev_err(dev, "Failed to find IRQ parent domain\n");
	return -ENODEV;		return -ENODEV;