Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 07d432bb authored by Jia-Ju Bai's avatar Jia-Ju Bai Committed by Doug Ledford
Browse files

rxe: Fix a sleep-in-atomic bug in post_one_send 



The driver may sleep under a spin lock, and the function call path is:
post_one_send (acquire the lock by spin_lock_irqsave)
  init_send_wqe
    copy_from_user --> may sleep

There is no flow that makes "qp->is_user" true, and copy_from_user may
cause bug when a non-user pointer is used. So the lines of copy_from_user
and check of "qp->is_user" are removed.

Signed-off-by: default avatarJia-Ju Bai <baijiaju1990@163.com>
Reviewed-by: default avatarLeon Romanovsky <leonro@mellanox.com>
Acked-by: default avatarMoni Shoua <monis@mellanox.com>
Signed-off-by: default avatarDoug Ledford <dledford@redhat.com>
parent e57bb6be

drivers/infiniband/sw/rxe/rxe_verbs.c

+2 −7
Original line number Diff line number Diff line
@@ -740,11 +740,6 @@ static int init_send_wqe(struct rxe_qp *qp, struct ib_send_wr *ibwr, 


		sge = ibwr->sg_list;

		for (i = 0; i < num_sge; i++, sge++) {

			if (qp->is_user && copy_from_user(p, (__user void *)

					    (uintptr_t)sge->addr, sge->length))

				return -EFAULT;



			else if (!qp->is_user)

			memcpy(p, (void *)(uintptr_t)sge->addr,

					sge->length);