Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 075c3fdd authored by Dan Williams's avatar Dan Williams
Browse files

libnvdimm/namespace: Clean up holder_class_store() 



Use sysfs_streq() in place of open-coded strcmp()'s that check for an
optional "\n" at the end of the input.

Reviewed-by: default avatarVishal Verma <vishal.l.verma@intel.com>
Signed-off-by: default avatarDan Williams <dan.j.williams@intel.com>
parent 316720b9

drivers/nvdimm/namespace_devs.c

+4 −4
Original line number Diff line number Diff line
@@ -1506,13 +1506,13 @@ static ssize_t __holder_class_store(struct device *dev, const char *buf) 
	if (dev->driver || ndns->claim)

		return -EBUSY;



	if (strcmp(buf, "btt") == 0 || strcmp(buf, "btt\n") == 0)

	if (sysfs_streq(buf, "btt"))

		ndns->claim_class = btt_claim_class(dev);

	else if (strcmp(buf, "pfn") == 0 || strcmp(buf, "pfn\n") == 0)

	else if (sysfs_streq(buf, "pfn"))

		ndns->claim_class = NVDIMM_CCLASS_PFN;

	else if (strcmp(buf, "dax") == 0 || strcmp(buf, "dax\n") == 0)

	else if (sysfs_streq(buf, "dax"))

		ndns->claim_class = NVDIMM_CCLASS_DAX;

	else if (strcmp(buf, "") == 0 || strcmp(buf, "\n") == 0)

	else if (sysfs_streq(buf, ""))

		ndns->claim_class = NVDIMM_CCLASS_NONE;

	else

		return -EINVAL;