Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0731160a authored by Mauro Carvalho Chehab's avatar Mauro Carvalho Chehab
Browse files

em28xx: don't load audio modules when AC97 is mis-detected 



With em2800 hardware, AC97 hardware can be detected even when it doesn't
exist. If, after probing for AC97, the driver won't find a companion
chip, simply prevents the load of the audio modules.

Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent 1ca31892

drivers/media/video/em28xx/em28xx-core.c

+8 −1
Original line number Diff line number Diff line
@@ -533,8 +533,15 @@ int em28xx_audio_setup(struct em28xx *dev) 


	vid1 = em28xx_read_ac97(dev, AC97_VENDOR_ID1);

	if (vid1 < 0) {

		/* Device likely doesn't support AC97 */

		/*

		 * Device likely doesn't support AC97

		 * Note: (some) em2800 devices without eeprom reports 0x91 on

		 *	 CHIPCFG register, even not having an AC97 chip

		 */

		em28xx_warn("AC97 chip type couldn't be determined\n");

		dev->audio_mode.ac97 = EM28XX_NO_AC97;

		dev->has_alsa_audio = 0;

		dev->audio_mode.has_audio = 0;

		goto init_audio;

	}