Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0730bd2e authored by Colin Ian King's avatar Colin Ian King Committed by Mark Brown
Browse files

ASoC: Intel: Skylake: fix memory leak of module on error exit path 



Currently there is a memory leak of module on a ENOMEM return path.
Fix this by kfree'ing module before returning.

Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 5919a389

sound/soc/intel/skylake/skl-sst-utils.c

+3 −1
Original line number Diff line number Diff line
@@ -349,8 +349,10 @@ int snd_skl_parse_uuids(struct sst_dsp *ctx, const struct firmware *fw, 
		module->max_instance = mod_entry->instance_max_count;

		size = sizeof(int) * mod_entry->instance_max_count;

		module->instance_id = devm_kzalloc(ctx->dev, size, GFP_KERNEL);

		if (!module->instance_id)

		if (!module->instance_id) {

			kfree(module);

			return -ENOMEM;

		}



		list_add_tail(&module->list, &skl->uuid_list);