Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 071cfc43 authored by Nishka Dasgupta's avatar Nishka Dasgupta Committed by Dmitry Torokhov
Browse files

Input: sun4i-lradc-keys - add of_node_put() before return 



Each iteration of for_each_child_of_node puts the previous
node, but in the case of a return from the middle of the loop, there is
no put, thus causing a memory leak. Hence add an of_node_put before the
return in three places.
Issue found with Coccinelle.

Signed-off-by: default avatarNishka Dasgupta <nishkadg.linux@gmail.com>
Signed-off-by: default avatarDmitry Torokhov <dmitry.torokhov@gmail.com>
parent 1976d7d2

drivers/input/keyboard/sun4i-lradc-keys.c

+3 −0
Original line number Diff line number Diff line
@@ -207,18 +207,21 @@ static int sun4i_lradc_load_dt_keymap(struct device *dev, 
		error = of_property_read_u32(pp, "channel", &channel);

		if (error || channel != 0) {

			dev_err(dev, "%pOFn: Inval channel prop\n", pp);

			of_node_put(pp);

			return -EINVAL;

		}



		error = of_property_read_u32(pp, "voltage", &map->voltage);

		if (error) {

			dev_err(dev, "%pOFn: Inval voltage prop\n", pp);

			of_node_put(pp);

			return -EINVAL;

		}



		error = of_property_read_u32(pp, "linux,code", &map->keycode);

		if (error) {

			dev_err(dev, "%pOFn: Inval linux,code prop\n", pp);

			of_node_put(pp);

			return -EINVAL;

		}