Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 07025f5b authored by Jack Pham's avatar Jack Pham Committed by Gerrit - the friendly Code Review server
Browse files

usb: pd: Do not respond to SVDM messages in PD 2.0 



Since our device does not support responding to Structured VDMs
(VIF Responds_to_Discov_SOP_DFP and Responds_to_Discov_SOP_UFP
fields are both false), any initiated discovery messages must
simply be ignored rather than responding with a NAK.

This addresses test failures observed in TEST.PD.VDM.SRC.1,
TEST.PD.VDM.SRC.2, TEST.PD.VDM.SNK.1, TEST.PD.VDM.SNK.2,
and TEST.PD.VDM.SNK.5 of the USB PD Merged tests.

Change-Id: I70f97563e528e4cf6d2a3bce31af7a7c702d4824
Signed-off-by: default avatarJack Pham <jackp@codeaurora.org>
parent a74d29a4

drivers/usb/pd/policy_engine.c

+0 −5
Original line number Diff line number Diff line
@@ -1634,11 +1634,6 @@ static void handle_vdm_rx(struct usbpd *pd, struct rx_msg *rx_msg) 
						0, SOP_MSG);

				if (ret)

					usbpd_set_state(pd, PE_SEND_SOFT_RESET);

			} else {

				usbpd_send_svdm(pd, svid, cmd,

						SVDM_CMD_TYPE_RESP_NAK,

						SVDM_HDR_OBJ_POS(vdm_hdr),

						NULL, 0);

			}

		}

		break;