Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 06c1895f authored by Mika Westerberg's avatar Mika Westerberg Committed by Greg Kroah-Hartman
Browse files

thunderbolt: Fix memory leak if ida_simple_get() fails in enumerate_services() 



commit a663e0df4a374b8537562a44d1cecafb472cd65b upstream.

The svc->key field is not released as it should be if ida_simple_get()
fails so fix that.

Fixes: 9aabb685 ("thunderbolt: Fix to check return value of ida_simple_get")
Cc: stable@vger.kernel.org
Signed-off-by: default avatarMika Westerberg <mika.westerberg@linux.intel.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 11c14da8

drivers/thunderbolt/xdomain.c

+1 −0
Original line number Diff line number Diff line
@@ -830,6 +830,7 @@ static void enumerate_services(struct tb_xdomain *xd) 


		id = ida_simple_get(&xd->service_ids, 0, 0, GFP_KERNEL);

		if (id < 0) {

			kfree(svc->key);

			kfree(svc);

			break;

		}