Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 06b5fc3a authored by Trond Myklebust's avatar Trond Myklebust
Browse files

Merge tag 'nfs-rdma-for-5.1-1' of git://git.linux-nfs.org/projects/anna/linux-nfs 



NFSoRDMA client updates for 5.1

New features:
- Convert rpc auth layer to use xdr_streams
- Config option to disable insecure enctypes
- Reduce size of RPC receive buffers

Bugfixes and cleanups:
- Fix sparse warnings
- Check inline size before providing a write chunk
- Reduce the receive doorbell rate
- Various tracepoint improvements

[Trond: Fix up merge conflicts]
Signed-off-by: default avatarTrond Myklebust <trond.myklebust@hammerspace.com>
parents 5085607d 2c94b8ec

fs/lockd/clnt4xdr.c

+0 −14
Original line number Diff line number Diff line
@@ -74,17 +74,6 @@ static void nlm4_compute_offsets(const struct nlm_lock *lock, 
		*l_len = loff_t_to_s64(fl->fl_end - fl->fl_start + 1);

}



/*

 * Handle decode buffer overflows out-of-line.

 */

static void print_overflow_msg(const char *func, const struct xdr_stream *xdr)

{

	dprintk("lockd: %s prematurely hit the end of our receive buffer. "

		"Remaining buffer length is %tu words.\n",

		func, xdr->end - xdr->p);

}





/*

 * Encode/decode NLMv4 basic data types

 *
@@ -176,7 +165,6 @@ static int decode_cookie(struct xdr_stream *xdr, 
	dprintk("NFS: returned cookie was too long: %u\n", length);

	return -EIO;

out_overflow:

	print_overflow_msg(__func__, xdr);

	return -EIO;

}
@@ -236,7 +224,6 @@ static int decode_nlm4_stat(struct xdr_stream *xdr, __be32 *stat) 
			__func__, be32_to_cpup(p));

	return -EIO;

out_overflow:

	print_overflow_msg(__func__, xdr);

	return -EIO;

}
@@ -309,7 +296,6 @@ static int decode_nlm4_holder(struct xdr_stream *xdr, struct nlm_res *result) 
out:

	return error;

out_overflow:

	print_overflow_msg(__func__, xdr);

	return -EIO;

}

fs/lockd/clntxdr.c

+0 −14
Original line number Diff line number Diff line
@@ -70,17 +70,6 @@ static void nlm_compute_offsets(const struct nlm_lock *lock, 
		*l_len = loff_t_to_s32(fl->fl_end - fl->fl_start + 1);

}



/*

 * Handle decode buffer overflows out-of-line.

 */

static void print_overflow_msg(const char *func, const struct xdr_stream *xdr)

{

	dprintk("lockd: %s prematurely hit the end of our receive buffer. "

		"Remaining buffer length is %tu words.\n",

		func, xdr->end - xdr->p);

}





/*

 * Encode/decode NLMv3 basic data types

 *
@@ -173,7 +162,6 @@ static int decode_cookie(struct xdr_stream *xdr, 
	dprintk("NFS: returned cookie was too long: %u\n", length);

	return -EIO;

out_overflow:

	print_overflow_msg(__func__, xdr);

	return -EIO;

}
@@ -231,7 +219,6 @@ static int decode_nlm_stat(struct xdr_stream *xdr, 
		__func__, be32_to_cpup(p));

	return -EIO;

out_overflow:

	print_overflow_msg(__func__, xdr);

	return -EIO;

}
@@ -303,7 +290,6 @@ static int decode_nlm_holder(struct xdr_stream *xdr, struct nlm_res *result) 
out:

	return error;

out_overflow:

	print_overflow_msg(__func__, xdr);

	return -EIO;

}

fs/nfs/callback_xdr.c

+28 −36
Original line number Diff line number Diff line
@@ -72,16 +72,6 @@ static int nfs4_encode_void(struct svc_rqst *rqstp, __be32 *p) 
	return xdr_ressize_check(rqstp, p);

}



static __be32 *read_buf(struct xdr_stream *xdr, size_t nbytes)

{

	__be32 *p;



	p = xdr_inline_decode(xdr, nbytes);

	if (unlikely(p == NULL))

		printk(KERN_WARNING "NFS: NFSv4 callback reply buffer overflowed!\n");

	return p;

}



static __be32 decode_string(struct xdr_stream *xdr, unsigned int *len,

		const char **str, size_t maxlen)

{
@@ -98,13 +88,13 @@ static __be32 decode_fh(struct xdr_stream *xdr, struct nfs_fh *fh) 
{

	__be32 *p;



	p = read_buf(xdr, 4);

	p = xdr_inline_decode(xdr, 4);

	if (unlikely(p == NULL))

		return htonl(NFS4ERR_RESOURCE);

	fh->size = ntohl(*p);

	if (fh->size > NFS4_FHSIZE)

		return htonl(NFS4ERR_BADHANDLE);

	p = read_buf(xdr, fh->size);

	p = xdr_inline_decode(xdr, fh->size);

	if (unlikely(p == NULL))

		return htonl(NFS4ERR_RESOURCE);

	memcpy(&fh->data[0], p, fh->size);
@@ -117,11 +107,11 @@ static __be32 decode_bitmap(struct xdr_stream *xdr, uint32_t *bitmap) 
	__be32 *p;

	unsigned int attrlen;



	p = read_buf(xdr, 4);

	p = xdr_inline_decode(xdr, 4);

	if (unlikely(p == NULL))

		return htonl(NFS4ERR_RESOURCE);

	attrlen = ntohl(*p);

	p = read_buf(xdr, attrlen << 2);

	p = xdr_inline_decode(xdr, attrlen << 2);

	if (unlikely(p == NULL))

		return htonl(NFS4ERR_RESOURCE);

	if (likely(attrlen > 0))
@@ -135,7 +125,7 @@ static __be32 decode_stateid(struct xdr_stream *xdr, nfs4_stateid *stateid) 
{

	__be32 *p;



	p = read_buf(xdr, NFS4_STATEID_SIZE);

	p = xdr_inline_decode(xdr, NFS4_STATEID_SIZE);

	if (unlikely(p == NULL))

		return htonl(NFS4ERR_RESOURCE);

	memcpy(stateid->data, p, NFS4_STATEID_SIZE);
@@ -156,7 +146,7 @@ static __be32 decode_compound_hdr_arg(struct xdr_stream *xdr, struct cb_compound 
	status = decode_string(xdr, &hdr->taglen, &hdr->tag, CB_OP_TAGLEN_MAXSZ);

	if (unlikely(status != 0))

		return status;

	p = read_buf(xdr, 12);

	p = xdr_inline_decode(xdr, 12);

	if (unlikely(p == NULL))

		return htonl(NFS4ERR_RESOURCE);

	hdr->minorversion = ntohl(*p++);
@@ -176,7 +166,7 @@ static __be32 decode_compound_hdr_arg(struct xdr_stream *xdr, struct cb_compound 
static __be32 decode_op_hdr(struct xdr_stream *xdr, unsigned int *op)

{

	__be32 *p;

	p = read_buf(xdr, 4);

	p = xdr_inline_decode(xdr, 4);

	if (unlikely(p == NULL))

		return htonl(NFS4ERR_RESOURCE_HDR);

	*op = ntohl(*p);
@@ -205,7 +195,7 @@ static __be32 decode_recall_args(struct svc_rqst *rqstp, 
	status = decode_delegation_stateid(xdr, &args->stateid);

	if (unlikely(status != 0))

		return status;

	p = read_buf(xdr, 4);

	p = xdr_inline_decode(xdr, 4);

	if (unlikely(p == NULL))

		return htonl(NFS4ERR_RESOURCE);

	args->truncate = ntohl(*p);
@@ -227,7 +217,7 @@ static __be32 decode_layoutrecall_args(struct svc_rqst *rqstp, 
	__be32 status = 0;

	uint32_t iomode;



	p = read_buf(xdr, 4 * sizeof(uint32_t));

	p = xdr_inline_decode(xdr, 4 * sizeof(uint32_t));

	if (unlikely(p == NULL))

		return htonl(NFS4ERR_BADXDR);
@@ -245,14 +235,14 @@ static __be32 decode_layoutrecall_args(struct svc_rqst *rqstp, 
		if (unlikely(status != 0))

			return status;



		p = read_buf(xdr, 2 * sizeof(uint64_t));

		p = xdr_inline_decode(xdr, 2 * sizeof(uint64_t));

		if (unlikely(p == NULL))

			return htonl(NFS4ERR_BADXDR);

		p = xdr_decode_hyper(p, &args->cbl_range.offset);

		p = xdr_decode_hyper(p, &args->cbl_range.length);

		return decode_layout_stateid(xdr, &args->cbl_stateid);

	} else if (args->cbl_recall_type == RETURN_FSID) {

		p = read_buf(xdr, 2 * sizeof(uint64_t));

		p = xdr_inline_decode(xdr, 2 * sizeof(uint64_t));

		if (unlikely(p == NULL))

			return htonl(NFS4ERR_BADXDR);

		p = xdr_decode_hyper(p, &args->cbl_fsid.major);
@@ -275,7 +265,7 @@ __be32 decode_devicenotify_args(struct svc_rqst *rqstp, 
	args->ndevs = 0;



	/* Num of device notifications */

	p = read_buf(xdr, sizeof(uint32_t));

	p = xdr_inline_decode(xdr, sizeof(uint32_t));

	if (unlikely(p == NULL)) {

		status = htonl(NFS4ERR_BADXDR);

		goto out;
@@ -298,7 +288,8 @@ __be32 decode_devicenotify_args(struct svc_rqst *rqstp, 
	for (i = 0; i < n; i++) {

		struct cb_devicenotifyitem *dev = &args->devs[i];



		p = read_buf(xdr, (4 * sizeof(uint32_t)) + NFS4_DEVICEID4_SIZE);

		p = xdr_inline_decode(xdr, (4 * sizeof(uint32_t)) +

				      NFS4_DEVICEID4_SIZE);

		if (unlikely(p == NULL)) {

			status = htonl(NFS4ERR_BADXDR);

			goto err;
@@ -329,7 +320,7 @@ __be32 decode_devicenotify_args(struct svc_rqst *rqstp, 
		p += XDR_QUADLEN(NFS4_DEVICEID4_SIZE);



		if (dev->cbd_layout_type == NOTIFY_DEVICEID4_CHANGE) {

			p = read_buf(xdr, sizeof(uint32_t));

			p = xdr_inline_decode(xdr, sizeof(uint32_t));

			if (unlikely(p == NULL)) {

				status = htonl(NFS4ERR_BADXDR);

				goto err;
@@ -359,7 +350,7 @@ static __be32 decode_sessionid(struct xdr_stream *xdr, 
{

	__be32 *p;



	p = read_buf(xdr, NFS4_MAX_SESSIONID_LEN);

	p = xdr_inline_decode(xdr, NFS4_MAX_SESSIONID_LEN);

	if (unlikely(p == NULL))

		return htonl(NFS4ERR_RESOURCE);
@@ -379,13 +370,13 @@ static __be32 decode_rc_list(struct xdr_stream *xdr, 
		goto out;



	status = htonl(NFS4ERR_RESOURCE);

	p = read_buf(xdr, sizeof(uint32_t));

	p = xdr_inline_decode(xdr, sizeof(uint32_t));

	if (unlikely(p == NULL))

		goto out;



	rc_list->rcl_nrefcalls = ntohl(*p++);

	if (rc_list->rcl_nrefcalls) {

		p = read_buf(xdr,

		p = xdr_inline_decode(xdr,

			     rc_list->rcl_nrefcalls * 2 * sizeof(uint32_t));

		if (unlikely(p == NULL))

			goto out;
@@ -418,7 +409,7 @@ static __be32 decode_cb_sequence_args(struct svc_rqst *rqstp, 
	if (status)

		return status;



	p = read_buf(xdr, 5 * sizeof(uint32_t));

	p = xdr_inline_decode(xdr, 5 * sizeof(uint32_t));

	if (unlikely(p == NULL))

		return htonl(NFS4ERR_RESOURCE);
@@ -461,7 +452,7 @@ static __be32 decode_recallany_args(struct svc_rqst *rqstp, 
	uint32_t bitmap[2];

	__be32 *p, status;



	p = read_buf(xdr, 4);

	p = xdr_inline_decode(xdr, 4);

	if (unlikely(p == NULL))

		return htonl(NFS4ERR_BADXDR);

	args->craa_objs_to_keep = ntohl(*p++);
@@ -480,7 +471,7 @@ static __be32 decode_recallslot_args(struct svc_rqst *rqstp, 
	struct cb_recallslotargs *args = argp;

	__be32 *p;



	p = read_buf(xdr, 4);

	p = xdr_inline_decode(xdr, 4);

	if (unlikely(p == NULL))

		return htonl(NFS4ERR_BADXDR);

	args->crsa_target_highest_slotid = ntohl(*p++);
@@ -492,14 +483,14 @@ static __be32 decode_lockowner(struct xdr_stream *xdr, struct cb_notify_lock_arg 
	__be32		*p;

	unsigned int	len;



	p = read_buf(xdr, 12);

	p = xdr_inline_decode(xdr, 12);

	if (unlikely(p == NULL))

		return htonl(NFS4ERR_BADXDR);



	p = xdr_decode_hyper(p, &args->cbnl_owner.clientid);

	len = be32_to_cpu(*p);



	p = read_buf(xdr, len);

	p = xdr_inline_decode(xdr, len);

	if (unlikely(p == NULL))

		return htonl(NFS4ERR_BADXDR);
@@ -537,7 +528,7 @@ static __be32 decode_write_response(struct xdr_stream *xdr, 
	__be32 *p;



	/* skip the always zero field */

	p = read_buf(xdr, 4);

	p = xdr_inline_decode(xdr, 4);

	if (unlikely(!p))

		goto out;

	p++;
@@ -577,7 +568,7 @@ static __be32 decode_offload_args(struct svc_rqst *rqstp, 
		return status;



	/* decode status */

	p = read_buf(xdr, 4);

	p = xdr_inline_decode(xdr, 4);

	if (unlikely(!p))

		goto out;

	args->error = ntohl(*p++);
@@ -943,10 +934,11 @@ static __be32 nfs4_callback_compound(struct svc_rqst *rqstp) 
	};

	unsigned int nops = 0;



	xdr_init_decode(&xdr_in, &rqstp->rq_arg, rqstp->rq_arg.head[0].iov_base);

	xdr_init_decode(&xdr_in, &rqstp->rq_arg,

			rqstp->rq_arg.head[0].iov_base, NULL);



	p = (__be32*)((char *)rqstp->rq_res.head[0].iov_base + rqstp->rq_res.head[0].iov_len);

	xdr_init_encode(&xdr_out, &rqstp->rq_res, p);

	xdr_init_encode(&xdr_out, &rqstp->rq_res, p, NULL);



	status = decode_compound_hdr_arg(&xdr_in, &hdr_arg);

	if (status == htonl(NFS4ERR_RESOURCE))

fs/nfs/flexfilelayout/flexfilelayout.c

+1 −1
Original line number Diff line number Diff line
@@ -2036,7 +2036,7 @@ ff_layout_encode_layoutreturn(struct xdr_stream *xdr, 


	dprintk("%s: Begin\n", __func__);



	xdr_init_encode(&tmp_xdr, &tmp_buf, NULL);

	xdr_init_encode(&tmp_xdr, &tmp_buf, NULL, NULL);



	ff_layout_encode_ioerr(&tmp_xdr, args, ff_args);

	ff_layout_encode_iostats_array(&tmp_xdr, args, ff_args);

fs/nfs/nfs2xdr.c

+40 −84
Original line number Diff line number Diff line
@@ -22,6 +22,7 @@ 
#include <linux/nfs.h>

#include <linux/nfs2.h>

#include <linux/nfs_fs.h>

#include "nfstrace.h"

#include "internal.h"



#define NFSDBG_FACILITY		NFSDBG_XDR
@@ -55,41 +56,15 @@ 


#define NFS_attrstat_sz		(1+NFS_fattr_sz)

#define NFS_diropres_sz		(1+NFS_fhandle_sz+NFS_fattr_sz)

#define NFS_readlinkres_sz	(2)

#define NFS_readres_sz		(1+NFS_fattr_sz+1)

#define NFS_readlinkres_sz	(2+1)

#define NFS_readres_sz		(1+NFS_fattr_sz+1+1)

#define NFS_writeres_sz         (NFS_attrstat_sz)

#define NFS_stat_sz		(1)

#define NFS_readdirres_sz	(1)

#define NFS_readdirres_sz	(1+1)

#define NFS_statfsres_sz	(1+NFS_info_sz)



static int nfs_stat_to_errno(enum nfs_stat);



/*

 * While encoding arguments, set up the reply buffer in advance to

 * receive reply data directly into the page cache.

 */

static void prepare_reply_buffer(struct rpc_rqst *req, struct page **pages,

				 unsigned int base, unsigned int len,

				 unsigned int bufsize)

{

	struct rpc_auth	*auth = req->rq_cred->cr_auth;

	unsigned int replen;



	replen = RPC_REPHDRSIZE + auth->au_rslack + bufsize;

	xdr_inline_pages(&req->rq_rcv_buf, replen << 2, pages, base, len);

}



/*

 * Handle decode buffer overflows out-of-line.

 */

static void print_overflow_msg(const char *func, const struct xdr_stream *xdr)

{

	dprintk("NFS: %s prematurely hit the end of our receive buffer. "

		"Remaining buffer length is %tu words.\n",

		func, xdr->end - xdr->p);

}





/*

 * Encode/decode NFSv2 basic data types

 *
@@ -110,8 +85,8 @@ static int decode_nfsdata(struct xdr_stream *xdr, struct nfs_pgio_res *result) 
	__be32 *p;



	p = xdr_inline_decode(xdr, 4);

	if (unlikely(p == NULL))

		goto out_overflow;

	if (unlikely(!p))

		return -EIO;

	count = be32_to_cpup(p);

	recvd = xdr_read_pages(xdr, count);

	if (unlikely(count > recvd))
@@ -125,9 +100,6 @@ static int decode_nfsdata(struct xdr_stream *xdr, struct nfs_pgio_res *result) 
		"count %u > recvd %u\n", count, recvd);

	count = recvd;

	goto out;

out_overflow:

	print_overflow_msg(__func__, xdr);

	return -EIO;

}



/*
@@ -157,13 +129,16 @@ static int decode_stat(struct xdr_stream *xdr, enum nfs_stat *status) 
	__be32 *p;



	p = xdr_inline_decode(xdr, 4);

	if (unlikely(p == NULL))

		goto out_overflow;

	if (unlikely(!p))

		return -EIO;

	if (unlikely(*p != cpu_to_be32(NFS_OK)))

		goto out_status;

	*status = 0;

	return 0;

out_status:

	*status = be32_to_cpup(p);

	trace_nfs_xdr_status((int)*status);

	return 0;

out_overflow:

	print_overflow_msg(__func__, xdr);

	return -EIO;

}



/*
@@ -205,14 +180,11 @@ static int decode_fhandle(struct xdr_stream *xdr, struct nfs_fh *fh) 
	__be32 *p;



	p = xdr_inline_decode(xdr, NFS2_FHSIZE);

	if (unlikely(p == NULL))

		goto out_overflow;

	if (unlikely(!p))

		return -EIO;

	fh->size = NFS2_FHSIZE;

	memcpy(fh->data, p, NFS2_FHSIZE);

	return 0;

out_overflow:

	print_overflow_msg(__func__, xdr);

	return -EIO;

}



/*
@@ -282,8 +254,8 @@ static int decode_fattr(struct xdr_stream *xdr, struct nfs_fattr *fattr) 
	__be32 *p;



	p = xdr_inline_decode(xdr, NFS_fattr_sz << 2);

	if (unlikely(p == NULL))

		goto out_overflow;

	if (unlikely(!p))

		return -EIO;



	fattr->valid |= NFS_ATTR_FATTR_V2;
@@ -325,9 +297,6 @@ static int decode_fattr(struct xdr_stream *xdr, struct nfs_fattr *fattr) 
out_gid:

	dprintk("NFS: returned invalid gid\n");

	return -EINVAL;

out_overflow:

	print_overflow_msg(__func__, xdr);

	return -EIO;

}



/*
@@ -416,23 +385,20 @@ static int decode_filename_inline(struct xdr_stream *xdr, 
	u32 count;



	p = xdr_inline_decode(xdr, 4);

	if (unlikely(p == NULL))

		goto out_overflow;

	if (unlikely(!p))

		return -EIO;

	count = be32_to_cpup(p);

	if (count > NFS3_MAXNAMLEN)

		goto out_nametoolong;

	p = xdr_inline_decode(xdr, count);

	if (unlikely(p == NULL))

		goto out_overflow;

	if (unlikely(!p))

		return -EIO;

	*name = (const char *)p;

	*length = count;

	return 0;

out_nametoolong:

	dprintk("NFS: returned filename too long: %u\n", count);

	return -ENAMETOOLONG;

out_overflow:

	print_overflow_msg(__func__, xdr);

	return -EIO;

}



/*
@@ -455,8 +421,8 @@ static int decode_path(struct xdr_stream *xdr) 
	__be32 *p;



	p = xdr_inline_decode(xdr, 4);

	if (unlikely(p == NULL))

		goto out_overflow;

	if (unlikely(!p))

		return -EIO;

	length = be32_to_cpup(p);

	if (unlikely(length >= xdr->buf->page_len || length > NFS_MAXPATHLEN))

		goto out_size;
@@ -472,9 +438,6 @@ static int decode_path(struct xdr_stream *xdr) 
	dprintk("NFS: server cheating in pathname result: "

		"length %u > received %u\n", length, recvd);

	return -EIO;

out_overflow:

	print_overflow_msg(__func__, xdr);

	return -EIO;

}



/*
@@ -615,7 +578,7 @@ static void nfs2_xdr_enc_readlinkargs(struct rpc_rqst *req, 
	const struct nfs_readlinkargs *args = data;



	encode_fhandle(xdr, args->fh);

	prepare_reply_buffer(req, args->pages, args->pgbase,

	rpc_prepare_reply_pages(req, args->pages, args->pgbase,

				args->pglen, NFS_readlinkres_sz);

}
@@ -651,7 +614,7 @@ static void nfs2_xdr_enc_readargs(struct rpc_rqst *req, 
	const struct nfs_pgio_args *args = data;



	encode_readargs(xdr, args);

	prepare_reply_buffer(req, args->pages, args->pgbase,

	rpc_prepare_reply_pages(req, args->pages, args->pgbase,

				args->count, NFS_readres_sz);

	req->rq_rcv_buf.flags |= XDRBUF_READ;

}
@@ -809,7 +772,7 @@ static void nfs2_xdr_enc_readdirargs(struct rpc_rqst *req, 
	const struct nfs_readdirargs *args = data;



	encode_readdirargs(xdr, args);

	prepare_reply_buffer(req, args->pages, 0,

	rpc_prepare_reply_pages(req, args->pages, 0,

				args->count, NFS_readdirres_sz);

}
@@ -951,12 +914,12 @@ int nfs2_decode_dirent(struct xdr_stream *xdr, struct nfs_entry *entry, 
	int error;



	p = xdr_inline_decode(xdr, 4);

	if (unlikely(p == NULL))

		goto out_overflow;

	if (unlikely(!p))

		return -EAGAIN;

	if (*p++ == xdr_zero) {

		p = xdr_inline_decode(xdr, 4);

		if (unlikely(p == NULL))

			goto out_overflow;

		if (unlikely(!p))

			return -EAGAIN;

		if (*p++ == xdr_zero)

			return -EAGAIN;

		entry->eof = 1;
@@ -964,8 +927,8 @@ int nfs2_decode_dirent(struct xdr_stream *xdr, struct nfs_entry *entry, 
	}



	p = xdr_inline_decode(xdr, 4);

	if (unlikely(p == NULL))

		goto out_overflow;

	if (unlikely(!p))

		return -EAGAIN;

	entry->ino = be32_to_cpup(p);



	error = decode_filename_inline(xdr, &entry->name, &entry->len);
@@ -978,17 +941,13 @@ int nfs2_decode_dirent(struct xdr_stream *xdr, struct nfs_entry *entry, 
	 */

	entry->prev_cookie = entry->cookie;

	p = xdr_inline_decode(xdr, 4);

	if (unlikely(p == NULL))

		goto out_overflow;

	if (unlikely(!p))

		return -EAGAIN;

	entry->cookie = be32_to_cpup(p);



	entry->d_type = DT_UNKNOWN;



	return 0;



out_overflow:

	print_overflow_msg(__func__, xdr);

	return -EAGAIN;

}



/*
@@ -1052,17 +1011,14 @@ static int decode_info(struct xdr_stream *xdr, struct nfs2_fsstat *result) 
	__be32 *p;



	p = xdr_inline_decode(xdr, NFS_info_sz << 2);

	if (unlikely(p == NULL))

		goto out_overflow;

	if (unlikely(!p))

		return -EIO;

	result->tsize  = be32_to_cpup(p++);

	result->bsize  = be32_to_cpup(p++);

	result->blocks = be32_to_cpup(p++);

	result->bfree  = be32_to_cpup(p++);

	result->bavail = be32_to_cpup(p);

	return 0;

out_overflow:

	print_overflow_msg(__func__, xdr);

	return -EIO;

}



static int nfs2_xdr_dec_statfsres(struct rpc_rqst *req, struct xdr_stream *xdr,