Commit 06ada44a authored Jun 25, 2018 by Alex Elder Committed by Andy Gross Sep 13, 2018

soc: qcom: smem: verify both host ids in partition header



The global partition is indicated by having both host values in its
table of contents entry equal SMEM_GLOBAL_HOST=0xfffe.

In qcom_smem_set_global_partition(), we check whether the header
structure at the beginning of the partition contains that host
value, but the check only verifies *one* of them.  Change the check
so the partition header must have SMEM_GLOBAL_HOST for *both* its
host fields.

Signed-off-by: Alex Elder <elder@linaro.org>
Signed-off-by: Andy Gross <andy.gross@linaro.org>

parent eb68cf09

drivers/soc/qcom/smem.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -770,7 +770,7 @@ static int qcom_smem_set_global_partition(struct qcom_smem *smem)
		return -EINVAL;
		}

		if (host0 != SMEM_GLOBAL_HOST && host1 != SMEM_GLOBAL_HOST) {
		if (host0 != SMEM_GLOBAL_HOST \|\| host1 != SMEM_GLOBAL_HOST) {
		dev_err(smem->dev, "Global partition hosts are invalid\n");
		return -EINVAL;
		}