Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 06668727 authored by Joe Perches's avatar Joe Perches Committed by Linus Torvalds
Browse files

checkpatch: update seq_<foo> tests 



seq_vprintf, seq_printf and seq_puts are logging functions and should be
allowed to exceed the maximium line length.

Add maximum line length exceptions for these functions.

Also, suggesting seq_printf conversions to seq_puts should be tested for
arguments after the format.

Signed-off-by: default avatarJoe Perches <joe@perches.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent d8b07710

scripts/checkpatch.pl

+4 −3
Original line number Diff line number Diff line
@@ -323,7 +323,8 @@ our $logFunctions = qr{(?x: 
	(?:[a-z0-9]+_){1,2}(?:printk|emerg|alert|crit|err|warning|warn|notice|info|debug|dbg|vdbg|devel|cont|WARN)(?:_ratelimited|_once|)|

	WARN(?:_RATELIMIT|_ONCE|)|

	panic|

	MODULE_[A-Z_]+

	MODULE_[A-Z_]+|

	seq_vprintf|seq_printf|seq_puts

)};



our $signature_tags = qr{(?xi:
@@ -3909,9 +3910,9 @@ sub string_find_replace { 
		}



# check for seq_printf uses that could be seq_puts

		if ($line =~ /\bseq_printf\s*\(/) {

		if ($sline =~ /\bseq_printf\s*\(.*"\s*\)\s*;\s*$/) {

			my $fmt = get_quoted_string($line, $rawline);

			if ($fmt !~ /[^\\]\%/) {

			if ($fmt ne "" && $fmt !~ /[^\\]\%/) {

				if (WARN("PREFER_SEQ_PUTS",

					 "Prefer seq_puts to seq_printf\n" . $herecurr) &&

				    $fix) {