Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 06564f60 authored by Colin Ian King's avatar Colin Ian King Committed by Doug Ledford
Browse files

IB/ocrdma: fix incorrect fall-through on switch statement 



In the case where mbox_status is OCRDMA_MBX_STATUS_FAILED and
add_status is OCRDMA_MBX_STATUS_FAILED err_num is assigned -EAGAIN
however the case OCRDMA_MBX_STATUS_FAILED is missing a break and
falls through to the default case which then re-assigns err_num
to -EFAULT.   Fix this so that err_num is assigned to -EAGAIN
for the add_status OCRDMA_MBX_STATUS_FAILED case and -EFAULT
otherwise.

Detected by CoverityScan CID#703125 ("Missing break in switch")

Fixes: fe2caefc ("RDMA/ocrdma: Add driver for Emulex OneConnect IBoE RDMA adapter")
Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Reviewed-by: default avatarLeon Romanovsky <leonro@mellanox.com>
Signed-off-by: default avatarDoug Ledford <dledford@redhat.com>
parent af3c79be

drivers/infiniband/hw/ocrdma/ocrdma_hw.c

+3 −0
Original line number Diff line number Diff line
@@ -252,7 +252,10 @@ static int ocrdma_get_mbx_errno(u32 status) 
		case OCRDMA_MBX_ADDI_STATUS_INSUFFICIENT_RESOURCES:

			err_num = -EAGAIN;

			break;

		default:

			err_num = -EFAULT;

		}

		break;

	default:

		err_num = -EFAULT;

	}