Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 062c9b04 authored by Joseph Qi's avatar Joseph Qi Committed by Greg Kroah-Hartman
Browse files

ext4: unlock xattr_sem properly in ext4_inline_data_truncate() 



commit 7067b2619017d51e71686ca9756b454de0e5826a upstream.

It takes xattr_sem to check inline data again but without unlock it
in case not have. So unlock it before return.

Fixes: aef1c851 ("ext4: let ext4_truncate handle inline data correctly")
Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Cc: Tao Ma <boyu.mt@taobao.com>
Signed-off-by: default avatarJoseph Qi <joseph.qi@linux.alibaba.com>
Reviewed-by: default avatarAndreas Dilger <adilger@dilger.ca>
Link: https://lore.kernel.org/r/1604370542-124630-1-git-send-email-joseph.qi@linux.alibaba.com


Signed-off-by: default avatarTheodore Ts'o <tytso@mit.edu>
Cc: stable@kernel.org
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent a6ca4c7e

fs/ext4/inline.c

+1 −0
Original line number Diff line number Diff line
@@ -1918,6 +1918,7 @@ int ext4_inline_data_truncate(struct inode *inode, int *has_inline) 


	ext4_write_lock_xattr(inode, &no_expand);

	if (!ext4_has_inline_data(inode)) {

		ext4_write_unlock_xattr(inode, &no_expand);

		*has_inline = 0;

		ext4_journal_stop(handle);

		return 0;