Commit 0624a8eb authored Aug 24, 2016 by Markus Elfring Committed by Christian Borntraeger Sep 08, 2016

KVM: s390: Use memdup_user() rather than duplicating code



* Reuse existing functionality from memdup_user() instead of keeping
  duplicate source code.

  This issue was detected by using the Coccinelle software.

* Return directly if this copy operation failed.

Reviewed-by: David Hildenbrand <dahi@linux.vnet.ibm.com>
Acked-by: Cornelia Huck <cornelia.huck@de.ibm.com>
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Message-Id: <c86f7520-885e-2829-ae9c-b81caa898e84@users.sourceforge.net>
Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>

parent a1708a2e

arch/s390/kvm/guestdbg.c

+4 −14

Original line number	Diff line number	Diff line
		@@ -216,20 +216,10 @@ int kvm_s390_import_bp_data(struct kvm_vcpu *vcpu,
		else if (dbg->arch.nr_hw_bp > MAX_BP_COUNT)
		return -EINVAL;

		bp_data = kmalloc_array(dbg->arch.nr_hw_bp,
		sizeof(*bp_data),
		GFP_KERNEL);
		if (!bp_data) {
		ret = -ENOMEM;
		goto error;
		}

		if (copy_from_user(bp_data,
		dbg->arch.hw_bp,
		sizeof(bp_data) dbg->arch.nr_hw_bp)) {
		ret = -EFAULT;
		goto error;
		}
		bp_data = memdup_user(dbg->arch.hw_bp,
		sizeof(bp_data) dbg->arch.nr_hw_bp);
		if (IS_ERR(bp_data))
		return PTR_ERR(bp_data);

		for (i = 0; i < dbg->arch.nr_hw_bp; i++) {
		switch (bp_data[i].type) {