Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 061b5c1d authored by Heiner Kallweit's avatar Heiner Kallweit Committed by Jacek Anaszewski
Browse files

leds: gpio: fix an unhandled error case in create_gpio_led 



gpiod_get_value_cansleep returns 0, 1, or an error code.
So far errors are not handled and treated the same as 1.
Change this to bail out if an error code is returned and
remove the double negation.

Signed-off-by: default avatarHeiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: default avatarJacek Anaszewski <j.anaszewski@samsung.com>
parent 68620e59

drivers/leds/leds-gpio.c

+6 −3
Original line number Diff line number Diff line
@@ -118,10 +118,13 @@ static int create_gpio_led(const struct gpio_led *template, 
		led_dat->platform_gpio_blink_set = blink_set;

		led_dat->cdev.blink_set = gpio_blink_set;

	}

	if (template->default_state == LEDS_GPIO_DEFSTATE_KEEP)

		state = !!gpiod_get_value_cansleep(led_dat->gpiod);

	else

	if (template->default_state == LEDS_GPIO_DEFSTATE_KEEP) {

		state = gpiod_get_value_cansleep(led_dat->gpiod);

		if (state < 0)

			return state;

	} else {

		state = (template->default_state == LEDS_GPIO_DEFSTATE_ON);

	}

	led_dat->cdev.brightness = state ? LED_FULL : LED_OFF;

	if (!template->retain_state_suspended)

		led_dat->cdev.flags |= LED_CORE_SUSPENDRESUME;