Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 05fd5c2c authored by Ronnie Sahlberg's avatar Ronnie Sahlberg Committed by Steve French
Browse files

cifs: fix memory leak in SMB2_read 



Commit 088aaf17 introduced a leak where
if SMB2_read() returned an error we would return without freeing the
request buffer.

Cc: Stable <stable@vger.kernel.org>
Signed-off-by: default avatarRonnie Sahlberg <lsahlber@redhat.com>
Reviewed-by: default avatarPavel Shilovsky <pshilov@microsoft.com>
Signed-off-by: default avatarSteve French <stfrench@microsoft.com>
parent ba25b50d

fs/cifs/smb2pdu.c

+1 −0
Original line number Diff line number Diff line
@@ -3466,6 +3466,7 @@ SMB2_read(const unsigned int xid, struct cifs_io_parms *io_parms, 
				    io_parms->tcon->tid, ses->Suid,

				    io_parms->offset, 0);

		free_rsp_buf(resp_buftype, rsp_iov.iov_base);

		cifs_small_buf_release(req);

		return rc == -ENODATA ? 0 : rc;

	} else

		trace_smb3_read_done(xid, req->PersistentFileId,