Commit 05804a7d authored Jul 15, 2021 by Riccardo Mancini Committed by Greg Kroah-Hartman Jul 28, 2021

perf test event_update: Fix memory leak of evlist



[ Upstream commit fc56f54f6fcd5337634f4545af6459613129b432 ]

ASan reports a memory leak when running:

  # perf test "49: Synthesize attr update"

Caused by evlist not being deleted.

This patch adds the missing evlist__delete and removes the
perf_cpu_map__put since it's already being deleted by evlist__delete.

Signed-off-by: Riccardo Mancini <rickyman7@gmail.com>
Fixes: a6e52817 ("perf tools: Add event_update event unit type")
Cc: Ian Rogers <irogers@google.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lore.kernel.org/lkml/f7994ad63d248f7645f901132d208fadf9f2b7e4.1626343282.git.rickyman7@gmail.com


Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent d257f3ab

tools/perf/tests/event_update.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -119,6 +119,6 @@ int test__event_update(struct test *test __maybe_unused, int subtest __maybe_unu
		TEST_ASSERT_VAL("failed to synthesize attr update cpus",
		!perf_event__synthesize_event_update_cpus(&tmp.tool, evsel, process_event_cpus));

		perf_cpu_map__put(evsel->core.own_cpus);
		evlist__delete(evlist);
		return 0;
		}