Commit 055cdd2e authored Sep 27, 2021 by Tim Gardner Committed by Greg Kroah-Hartman Apr 15, 2022

video: fbdev: nvidiafb: Use strscpy() to prevent buffer overflow



[ Upstream commit 37a1a2e6eeeb101285cd34e12e48a881524701aa ]

Coverity complains of a possible buffer overflow. However,
given the 'static' scope of nvidia_setup_i2c_bus() it looks
like that can't happen after examiniing the call sites.

CID 19036 (#1 of 1): Copy into fixed size buffer (STRING_OVERFLOW)
1. fixed_size_dest: You might overrun the 48-character fixed-size string
  chan->adapter.name by copying name without checking the length.
2. parameter_as_source: Note: This defect has an elevated risk because the
  source argument is a parameter of the current function.
 89        strcpy(chan->adapter.name, name);

Fix this warning by using strscpy() which will silence the warning and
prevent any future buffer overflows should the names used to identify the
channel become much longer.

Cc: Antonino Daplas <adaplas@gmail.com>
Cc: linux-fbdev@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
Signed-off-by: Helge Deller <deller@gmx.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent fe41ad8b

drivers/video/fbdev/nvidia/nv_i2c.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -86,7 +86,7 @@ static int nvidia_setup_i2c_bus(struct nvidia_i2c_chan chan, const char name,
		{
		int rc;

		strcpy(chan->adapter.name, name);
		strscpy(chan->adapter.name, name, sizeof(chan->adapter.name));
		chan->adapter.owner = THIS_MODULE;
		chan->adapter.class = i2c_class;
		chan->adapter.algo_data = &chan->algo;