Commit 05414dd1 authored Apr 21, 2019 by Ido Schimmel Committed by David S. Miller Apr 21, 2019

mlxsw: spectrum_router: Relax FIB rule validation



Currently, mlxsw does not support policy-based routing (PBR) and
therefore forbids the installation of non-default FIB rules except for
the l3mdev rule which is used for VRFs.

Relax the check to allow the installation of FIB rules that would never
match packets received by the device. Specifically, if the iif is that
of the loopback netdev. This is useful for users that need to redirect
locally generated packets based on FIB rules.

Signed-off-by: Ido Schimmel <idosch@mellanox.com>
Acked-by: Jiri Pirko <jiri@mellanox.com>
Tested-by: Alexander Petrovskiy <alexpe@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent fa73989f

drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c

+4 −0

Original line number	Diff line number	Diff line
		@@ -6050,6 +6050,10 @@ static int mlxsw_sp_router_fib_rule_event(unsigned long event,
		fr_info = container_of(info, struct fib_rule_notifier_info, info);
		rule = fr_info->rule;

		/* Rule only affects locally generated traffic */
		if (rule->iifindex == info->net->loopback_dev->ifindex)
		return 0;

		switch (info->family) {
		case AF_INET:
		if (!fib4_rule_default(rule) && !rule->l3mdev)