Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 052b93d0 authored by Mariusz Stachura's avatar Mariusz Stachura Committed by Jeff Kirsher
Browse files

i40e: do not enter PHY debug mode while setting LEDs behaviour 



Previous implementation of LED set/get functions required to enter
PHY debug mode, in order to prevent access to it from FW and SW at
the same time. Reset of all ports was a unwanted side effect.

Signed-off-by: default avatarMariusz Stachura <mariusz.stachura@intel.com>
Tested-by: default avatarAndrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
parent 19b7960b

drivers/net/ethernet/intel/i40e/i40e_ethtool.c

+5 −2
Original line number Diff line number Diff line
@@ -2010,7 +2010,9 @@ static int i40e_set_phys_id(struct net_device *netdev, 
		if (!(pf->hw_features & I40E_HW_PHY_CONTROLS_LEDS)) {

			pf->led_status = i40e_led_get(hw);

		} else {

			i40e_aq_set_phy_debug(hw, I40E_PHY_DEBUG_ALL, NULL);

			if (!(hw->flags & I40E_HW_FLAG_AQ_PHY_ACCESS_CAPABLE))

				i40e_aq_set_phy_debug(hw, I40E_PHY_DEBUG_ALL,

						      NULL);

			ret = i40e_led_get_phy(hw, &temp_status,

					       &pf->phy_led_val);

			pf->led_status = temp_status;
@@ -2035,6 +2037,7 @@ static int i40e_set_phys_id(struct net_device *netdev, 
			ret = i40e_led_set_phy(hw, false, pf->led_status,

					       (pf->phy_led_val |

					       I40E_PHY_LED_MODE_ORIG));

			if (!(hw->flags & I40E_HW_FLAG_AQ_PHY_ACCESS_CAPABLE))

				i40e_aq_set_phy_debug(hw, 0, NULL);

		}

		break;