Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0523cdc6 authored by Kishon Vijay Abraham I's avatar Kishon Vijay Abraham I Committed by Lorenzo Pieralisi
Browse files

PCI: keystone: Use ERR_IRQ_STATUS instead of ERR_IRQ_STATUS_RAW to get interrupt status 



Use ERR_IRQ_STATUS instead of ERR_IRQ_STATUS_RAW to get interrupt
status. ERR_IRQ_STATUS_RAW has the status of the interrupts
before masking whereas ERR_IRQ_STATUS has the status of the interrupts
after masking. Since all the interrupts are unmasked here, use
ERR_IRQ_STATUS.

Signed-off-by: default avatarKishon Vijay Abraham I <kishon@ti.com>
Signed-off-by: default avatarLorenzo Pieralisi <lorenzo.pieralisi@arm.com>
parent 23fe5bd4

drivers/pci/controller/dwc/pci-keystone.c

+1 −2
Original line number Diff line number Diff line
@@ -80,7 +80,6 @@ 
#define ERR_IRQ_ALL	(ERR_AER | ERR_AXI | ERR_CORR | \

			 ERR_NONFATAL | ERR_FATAL | ERR_SYS)

#define ERR_FATAL_IRQ	(ERR_FATAL | ERR_AXI)

#define ERR_IRQ_STATUS_RAW		0x1c0

#define ERR_IRQ_STATUS			0x1c4

#define ERR_IRQ_ENABLE_SET		0x1c8

#define ERR_IRQ_ENABLE_CLR		0x1cc
@@ -249,7 +248,7 @@ static irqreturn_t ks_pcie_handle_error_irq(struct keystone_pcie *ks_pcie) 
{

	u32 status;



	status = ks_pcie_app_readl(ks_pcie, ERR_IRQ_STATUS_RAW) & ERR_IRQ_ALL;

	status = ks_pcie_app_readl(ks_pcie, ERR_IRQ_STATUS);

	if (!status)

		return IRQ_NONE;