Commit 04b06716 authored Jul 13, 2021 by Pavel Skripkin Committed by Greg Kroah-Hartman Jul 25, 2021

net: fddi: fix UAF in fza_probe



commit deb7178eb940e2c5caca1b1db084a69b2e59b4c9 upstream.

fp is netdev private data and it cannot be
used after free_netdev() call. Using fp after free_netdev()
can cause UAF bug. Fix it by moving free_netdev() after error message.

Fixes: 61414f5e ("FDDI: defza: Add support for DEC FDDIcontroller 700
TURBOchannel adapter")
Signed-off-by: Pavel Skripkin <paskripkin@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 8aa13a86

drivers/net/fddi/defza.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -1504,9 +1504,8 @@ static int fza_probe(struct device *bdev)
		release_mem_region(start, len);

		err_out_kfree:
		free_netdev(dev);

		pr_err("%s: initialization failure, aborting!\n", fp->name);
		free_netdev(dev);
		return ret;
		}