Commit 04a4af33 authored Jan 14, 2019 by Ross Lagerwall Committed by David S. Miller Jan 16, 2019

openvswitch: Avoid OOB read when parsing flow nlattrs



For nested and variable attributes, the expected length of an attribute
is not known and marked by a negative number.  This results in an OOB
read when the expected length is later used to check if the attribute is
all zeros. Fix this by using the actual length of the attribute rather
than the expected length.

Signed-off-by: Ross Lagerwall <ross.lagerwall@citrix.com>
Acked-by: Pravin B Shelar <pshelar@ovn.org>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 9098f21f

net/openvswitch/flow_netlink.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -500,7 +500,7 @@ static int __parse_flow_nlattrs(const struct nlattr *attr,
		return -EINVAL;
		}

		if (!nz \|\| !is_all_zero(nla_data(nla), expected_len)) {
		if (!nz \|\| !is_all_zero(nla_data(nla), nla_len(nla))) {
		attrs \|= 1 << type;
		a[type] = nla;
		}