Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 049b4d10 authored by Asbjørn Sloth Tønnesen's avatar Asbjørn Sloth Tønnesen Committed by Greg Kroah-Hartman
Browse files

net: qede: use return from qede_parse_flow_attr() for flow_spec 



[ Upstream commit 27b44414a34b108c5a37cd5b4894f606061d86e7 ]

In qede_flow_spec_to_rule(), when calling
qede_parse_flow_attr() then the return code
was only used for a non-zero check, and then
-EINVAL was returned.

qede_parse_flow_attr() can currently fail with:
* -EINVAL
* -EOPNOTSUPP
* -EPROTONOSUPPORT

This patch changes the code to use the actual
return code, not just return -EINVAL.

The blaimed commit introduced qede_flow_spec_to_rule(),
and this call to qede_parse_flow_attr(), it looks
like it just duplicated how it was already used.

Only compile tested.

Fixes: 37c5d3ef ("qede: use ethtool_rx_flow_rule() to remove duplicated parser code")
Signed-off-by: default avatarAsbjørn Sloth Tønnesen <ast@fiberby.net>
Reviewed-by: default avatarSimon Horman <horms@kernel.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 8155d5a5

drivers/net/ethernet/qlogic/qede/qede_filter.c

+2 −3
Original line number Diff line number Diff line
@@ -2079,10 +2079,9 @@ static int qede_flow_spec_to_rule(struct qede_dev *edev, 
	if (IS_ERR(flow))

		return PTR_ERR(flow);



	if (qede_parse_flow_attr(edev, proto, flow->rule, t)) {

		err = -EINVAL;

	err = qede_parse_flow_attr(edev, proto, flow->rule, t);

	if (err)

		goto err_out;

	}



	/* Make sure location is valid and filter isn't already set */

	err = qede_flow_spec_validate(edev, &flow->rule->action, t,