Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0470e5e3 authored by Qian Cai's avatar Qian Cai Committed by Saeed Mahameed
Browse files

net/mlx5: fix -Wtype-limits compilation warnings 



The commit b9a7ba55 ("net/mlx5: Use event mask based on device
capabilities") introduced a few compilation warnings due to it bumps
MLX5_EVENT_TYPE_MAX from 0x27 to 0x100 which is always greater than
an "struct {mlx5_eqe|mlx5_nb}.type" that is an "u8".

drivers/net/ethernet/mellanox/mlx5/core/eq.c: In function
'mlx5_eq_notifier_register':
drivers/net/ethernet/mellanox/mlx5/core/eq.c:948:21: warning: comparison
is always false due to limited range of data type [-Wtype-limits]
  if (nb->event_type >= MLX5_EVENT_TYPE_MAX)
                     ^~
drivers/net/ethernet/mellanox/mlx5/core/eq.c: In function
'mlx5_eq_notifier_unregister':
drivers/net/ethernet/mellanox/mlx5/core/eq.c:959:21: warning: comparison
is always false due to limited range of data type [-Wtype-limits]
  if (nb->event_type >= MLX5_EVENT_TYPE_MAX)

Fix them by removing unnecessary checkings.

Fixes: b9a7ba55 ("net/mlx5: Use event mask based on device capabilities")
Signed-off-by: default avatarQian Cai <cai@lca.pw>
Signed-off-by: default avatarSaeed Mahameed <saeedm@mellanox.com>
parent 5f9e832c

drivers/net/ethernet/mellanox/mlx5/core/eq.c

+1 −11
Original line number Diff line number Diff line
@@ -215,11 +215,7 @@ static int mlx5_eq_async_int(struct notifier_block *nb, 
		 */

		dma_rmb();



		if (likely(eqe->type < MLX5_EVENT_TYPE_MAX))

		atomic_notifier_call_chain(&eqt->nh[eqe->type], eqe->type, eqe);

		else

			mlx5_core_warn_once(dev, "notifier_call_chain is not setup for eqe: %d\n", eqe->type);



		atomic_notifier_call_chain(&eqt->nh[MLX5_EVENT_TYPE_NOTIFY_ANY], eqe->type, eqe);



		++eq->cons_index;
@@ -945,9 +941,6 @@ int mlx5_eq_notifier_register(struct mlx5_core_dev *dev, struct mlx5_nb *nb) 
{

	struct mlx5_eq_table *eqt = dev->priv.eq_table;



	if (nb->event_type >= MLX5_EVENT_TYPE_MAX)

		return -EINVAL;



	return atomic_notifier_chain_register(&eqt->nh[nb->event_type], &nb->nb);

}

EXPORT_SYMBOL(mlx5_eq_notifier_register);
@@ -956,9 +949,6 @@ int mlx5_eq_notifier_unregister(struct mlx5_core_dev *dev, struct mlx5_nb *nb) 
{

	struct mlx5_eq_table *eqt = dev->priv.eq_table;



	if (nb->event_type >= MLX5_EVENT_TYPE_MAX)

		return -EINVAL;



	return atomic_notifier_chain_unregister(&eqt->nh[nb->event_type], &nb->nb);

}

EXPORT_SYMBOL(mlx5_eq_notifier_unregister);