Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 043a6806 authored by Bart Van Assche's avatar Bart Van Assche Committed by Doug Ledford
Browse files

IB/srpt: Log out all initiators if a port is disabled 



If an initiator observes LUN deletion during shutdown of the
target stack then that will trigger an I/O error even when using
multipathd. Users need a way to avoid that shutting down the
target stack causes I/O errors, e.g. by providing a way to force
initiator logout. Hence close all sessions if a target port is
disabled.

Signed-off-by: default avatarBart Van Assche <bart.vanassche@sandisk.com>
Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Reviewed-by: default avatarAlex Estrin <alex.estrin@intel.com>
Cc: Sagi Grimberg <sagig@mellanox.com>
Signed-off-by: default avatarDoug Ledford <dledford@redhat.com>
parent fc3af58d

drivers/infiniband/ulp/srpt/ib_srpt.c

+19 −4
Original line number Diff line number Diff line
@@ -3152,6 +3152,8 @@ static ssize_t srpt_tpg_enable_store(struct config_item *item, 
{

	struct se_portal_group *se_tpg = to_tpg(item);

	struct srpt_port *sport = container_of(se_tpg, struct srpt_port, port_tpg_1);

	struct srpt_device *sdev = sport->sdev;

	struct srpt_rdma_ch *ch;

	unsigned long tmp;

        int ret;
@@ -3165,11 +3167,24 @@ static ssize_t srpt_tpg_enable_store(struct config_item *item, 
		pr_err("Illegal value for srpt_tpg_store_enable: %lu\n", tmp);

		return -EINVAL;

	}

	if (tmp == 1)

		sport->enabled = true;

	else

		sport->enabled = false;

	if (sport->enabled == tmp)

		goto out;

	sport->enabled = tmp;

	if (sport->enabled)

		goto out;



	mutex_lock(&sdev->mutex);

	list_for_each_entry(ch, &sdev->rch_list, list) {

		if (ch->sport == sport) {

			pr_debug("%s: ch %p %s-%d\n", __func__, ch,

				 ch->sess_name, ch->qp->qp_num);

			srpt_disconnect_ch(ch);

			srpt_close_ch(ch);

		}

	}

	mutex_unlock(&sdev->mutex);



out:

	return count;

}