Commit 03db4fe7 authored Aug 21, 2023 by Peng Fan Committed by Greg Kroah-Hartman Sep 23, 2023

amba: bus: fix refcount leak



[ Upstream commit e312cbdc11305568554a9e18a2ea5c2492c183f3 ]

commit 5de1540b ("drivers/amba: create devices from device tree")
increases the refcount of of_node, but not releases it in
amba_device_release, so there is refcount leak. By using of_node_put
to avoid refcount leak.

Fixes: 5de1540b ("drivers/amba: create devices from device tree")
Signed-off-by: Peng Fan <peng.fan@nxp.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20230821023928.3324283-1-peng.fan@oss.nxp.com


Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 93a4aefa

drivers/amba/bus.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -364,6 +364,7 @@ static void amba_device_release(struct device *dev)
		{
		struct amba_device *d = to_amba_device(dev);

		of_node_put(d->dev.of_node);
		if (d->res.parent)
		release_resource(&d->res);
		kfree(d);