Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 03c5b534 authored by Eric Dumazet's avatar Eric Dumazet Committed by David S. Miller
Browse files

ipv6: fix inet6_lookup_listener() 



A stupid refactoring bug in inet6_lookup_listener() needs to be fixed
in order to get proper SO_REUSEPORT behavior.

Fixes: 3b24d854 ("tcp/dccp: do not touch listener sk_refcnt under synflood")
Signed-off-by: default avatarEric Dumazet <edumazet@google.com>
Reported-by: default avatarMaciej Żenczykowski <maze@google.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 498cd8e4

net/ipv6/inet6_hashtables.c

+2 −2
Original line number Diff line number Diff line
@@ -137,7 +137,7 @@ struct sock *inet6_lookup_listener(struct net *net, 
	sk_for_each(sk, &ilb->head) {

		score = compute_score(sk, net, hnum, daddr, dif);

		if (score > hiscore) {

			hiscore = score;

			reuseport = sk->sk_reuseport;

			if (reuseport) {

				phash = inet6_ehashfn(net, daddr, hnum,

						      saddr, sport);
@@ -148,7 +148,7 @@ struct sock *inet6_lookup_listener(struct net *net, 
				matches = 1;

			}

			result = sk;

			reuseport = sk->sk_reuseport;

			hiscore = score;

		} else if (score == hiscore && reuseport) {

			matches++;

			if (reciprocal_scale(phash, matches) == 0)