Commit 03af69bd authored Mar 29, 2023 by Paulo Alcantara Committed by Greg Kroah-Hartman Apr 05, 2023

cifs: prevent infinite recursion in CIFSGetDFSRefer()



commit 09ba47b44d26b475bbdf9c80db9e0193d2b58956 upstream.

We can't call smb_init() in CIFSGetDFSRefer() as cifs_reconnect_tcon()
may end up calling CIFSGetDFSRefer() again to get new DFS referrals
and thus causing an infinite recursion.

Signed-off-by: Paulo Alcantara (SUSE) <pc@manguebit.com>
Reviewed-by: Ronnie Sahlberg <lsahlber@redhat.com>
Cc: stable@vger.kernel.org # 6.2
Signed-off-by: Steve French <stfrench@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 51d65737

fs/cifs/cifssmb.c

+7 −2

Original line number	Diff line number	Diff line
		@@ -4933,8 +4933,13 @@ CIFSGetDFSRefer(const unsigned int xid, struct cifs_ses *ses,
		return -ENODEV;

		getDFSRetry:
		rc = smb_init(SMB_COM_TRANSACTION2, 15, ses->tcon_ipc, (void **) &pSMB,
		(void **) &pSMBr);
		/*
		* Use smb_init_no_reconnect() instead of smb_init() as
		* CIFSGetDFSRefer() may be called from cifs_reconnect_tcon() and thus
		* causing an infinite recursion.
		*/
		rc = smb_init_no_reconnect(SMB_COM_TRANSACTION2, 15, ses->tcon_ipc,
		(void )&pSMB, (void )&pSMBr);
		if (rc)
		return rc;